Skip to content

chore(pipelines): rename e2e-rcv1p.yaml -> e2e-rcv1p-not-opted-in.yaml#8881

Open
rchincha wants to merge 1 commit into
mainfrom
rchinchani/rename-rcv1p-not-opted-in
Open

chore(pipelines): rename e2e-rcv1p.yaml -> e2e-rcv1p-not-opted-in.yaml#8881
rchincha wants to merge 1 commit into
mainfrom
rchinchani/rename-rcv1p-not-opted-in

Conversation

@rchincha

Copy link
Copy Markdown
Contributor

Addresses review feedback (r3554432549, cameronmeissner) on PR #8096: the .pipelines/e2e-rcv1p.yaml pipeline is named generically but actually runs ONLY the "not-opted-in" (negative) RCV1P suite. It forces rcv1pTagsAutoInjected: false so tests like Test_RCV1P_*_NotOptedIn can validate behavior in a subscription that does NOT auto-inject the opt-in VMSS tag. The opt-in/positive RCV1P run lives in aks-rp (linux-release-orchestration.yaml, JOB_NAME=abe2e_rcv1p, TAGS_TO_RUN=rcv1pcertmode=true) against the TME-RCV1P subscription that auto-injects the tag.

Renaming makes the intent obvious and removes the confusion the reviewer called out. Also drops the stale "A follow-up PR will rename this file..." comment inside the YAML, since the follow-up is now this PR.

Dependency analysis

AgentBaker (this repo):

  • git grep e2e-rcv1p -> only .pipelines/e2e-rcv1p.yaml itself (now renamed). No workflows, no scripts, no README references the filename.

aks-rp (msazure/CloudNativeCompute/aks-rp):

  • git grep e2e-rcv1p -> 0 hits.
  • git grep -i rcv1p -> only .pipelines/agentbaker/templates/linux-release-orchestration.yaml, which references RCV1P purely by test tag (TAGS_TO_RUN=rcv1pcertmode=true) and by subscription id ($(E2E_SUBSCRIPTION_ID_RCV1P)). It queues the "Agentbaker E2E - TME Tenant" definition (id 451455, yaml path .pipelines/e2e-tme.yaml) via vhdbuilder e2e ab --run-tags rcv1pcertmode=true, NOT the pipeline being renamed here. => No aks-rp change required.

Azure DevOps

Enumerated all 20 CloudNativeCompute pipeline definitions bound to the Azure/AgentBaker GitHub repo (via az pipelines list ... --repository Azure/AgentBaker --repository-type gitHub and az pipelines show --query process.yamlFilename). NONE of them are currently registered against .pipelines/e2e-rcv1p.yaml, so this rename requires no ADO-side pipeline definition edit.

If/when someone later registers an ADO pipeline for the not-opted-in suite, they should point it at the new path
.pipelines/e2e-rcv1p-not-opted-in.yaml. Any ADO pipeline that is later found to still reference the old path can be updated at: https://dev.azure.com/msazure/CloudNativeCompute/_build (Edit -> Triggers -> YAML file path).

Verification

  • git grep e2e-rcv1p.yaml -> 0 hits after rename.
  • git grep e2e-rcv1p-not-opted-in.yaml -> 1 hit (the renamed file itself).

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings July 10, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the intent of the RCV1P E2E pipeline YAML by updating the header comments to accurately state that it runs only the “not-opted-in” (negative) RCV1P scenarios, and removes a stale note about a future rename (now complete per PR intent).

Changes:

  • Updated the pipeline header comment to explicitly describe the “not-opted-in” (negative) RCV1P suite behavior.
  • Removed the outdated “follow-up PR will rename this file” comment now that the pipeline file is named accordingly.

Addresses review feedback (r3554432549, cameronmeissner) on PR #8096:
the .pipelines/e2e-rcv1p.yaml pipeline is named generically but actually
runs ONLY the "not-opted-in" (negative) RCV1P suite. It forces
`rcv1pTagsAutoInjected: false` so tests like Test_RCV1P_*_NotOptedIn can
validate behavior in a subscription that does NOT auto-inject the opt-in
VMSS tag. The opt-in/positive RCV1P run lives in aks-rp
(linux-release-orchestration.yaml, JOB_NAME=abe2e_rcv1p,
TAGS_TO_RUN=rcv1pcertmode=true) against the TME-RCV1P subscription that
auto-injects the tag.

Renaming makes the intent obvious and removes the confusion the reviewer
called out. Also drops the stale "A follow-up PR will rename this file..."
comment inside the YAML, since the follow-up is now this PR.

Dependency analysis
-------------------
AgentBaker (this repo):
  * `git grep e2e-rcv1p` -> only .pipelines/e2e-rcv1p.yaml itself (now
    renamed). No workflows, no scripts, no README references the filename.

aks-rp (msazure/CloudNativeCompute/aks-rp):
  * `git grep e2e-rcv1p` -> 0 hits.
  * `git grep -i rcv1p` -> only
    .pipelines/agentbaker/templates/linux-release-orchestration.yaml, which
    references RCV1P purely by test tag (TAGS_TO_RUN=rcv1pcertmode=true)
    and by subscription id ($(E2E_SUBSCRIPTION_ID_RCV1P)). It queues the
    "Agentbaker E2E - TME Tenant" definition (id 451455, yaml path
    .pipelines/e2e-tme.yaml) via `vhdbuilder e2e ab --run-tags
    rcv1pcertmode=true`, NOT the pipeline being renamed here.
  => No aks-rp change required.

Azure DevOps
------------
Enumerated all 20 CloudNativeCompute pipeline definitions bound to the
Azure/AgentBaker GitHub repo (via `az pipelines list ... --repository
Azure/AgentBaker --repository-type gitHub` and `az pipelines show
--query process.yamlFilename`). NONE of them are currently registered
against `.pipelines/e2e-rcv1p.yaml`, so this rename requires no ADO-side
pipeline definition edit.

If/when someone later registers an ADO pipeline for the not-opted-in
suite, they should point it at the new path
`.pipelines/e2e-rcv1p-not-opted-in.yaml`. Any ADO pipeline that is later
found to still reference the old path can be updated at:
https://dev.azure.com/msazure/CloudNativeCompute/_build (Edit -> Triggers
-> YAML file path).

Verification
------------
  * git grep e2e-rcv1p.yaml -> 0 hits after rename.
  * git grep e2e-rcv1p-not-opted-in.yaml -> 1 hit (the renamed file
    itself).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants