Skip to content

[AutoPR azure-resourcemanager-authorization]-generated-from-SDK Generation - Java-6131697#48751

Merged
weidongxu-microsoft merged 2 commits intomainfrom
sdkauto/azure-resourcemanager-authorization-6131697
Apr 17, 2026
Merged

[AutoPR azure-resourcemanager-authorization]-generated-from-SDK Generation - Java-6131697#48751
weidongxu-microsoft merged 2 commits intomainfrom
sdkauto/azure-resourcemanager-authorization-6131697

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Configurations: 'specification/authorization/resource-manager/Microsoft.Authorization/Authorization/tspconfig.yaml', API Version: 2024-07-01-preview, SDK Release Type: beta, and CommitSHA: '14ea458babe962d08b39acbb244bb81bdd3cb999' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6131697 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…ft.Authorization/Authorization/tspconfig.yaml', API Version: 2024-07-01-preview, SDK Release Type: beta, and CommitSHA: '14ea458babe962d08b39acbb244bb81bdd3cb999' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6131697 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-authorization

@jruttle
Copy link
Copy Markdown

jruttle commented Apr 13, 2026

Hi @weidongxu-microsoft @XiaofeiCao — could you take a look at this AutoPR when you get a chance? It adds deny assignment create/delete support to azure-resourcemanager-authorization (generated from the merged TypeSpec PR azure-rest-api-specs#41617). Happy to help with anything needed. Thanks!

Copy link
Copy Markdown
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiaofeiCao for review as well

@jruttle
Copy link
Copy Markdown

jruttle commented Apr 17, 2026

Hi @weidongxu-microsoft @XiaofeiCao — thank you both for approving this PR! 🎉

It's still marked as draft though, which I believe is preventing it from being merged. Could one of you undraft it and complete the merge? All checks are passing and it has two approvals. Thanks! 🙏

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review April 17, 2026 08:27
Copilot AI review requested due to automatic review settings April 17, 2026 08:27
@weidongxu-microsoft weidongxu-microsoft merged commit d86dd5d into main Apr 17, 2026
18 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the sdkauto/azure-resourcemanager-authorization-6131697 branch April 17, 2026 08:28
@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented Apr 17, 2026

@jruttle

It is really service task to undraft the PR. Otherwise SDK dev would think the PR not ready to process.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the azure-resourcemanager-authorization generated SDK from the Authorization TypeSpec configuration, aligning generated models/clients and metadata with the referenced azure-rest-api-specs commit.

Changes:

  • Updated tsp-location.yaml to point at a new spec repo commit SHA.
  • Regenerated models/clients (notably scope path encoding changes and a user-type enum rename).
  • Updated changelog entries for the new beta.

Reviewed changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/authorization/azure-resourcemanager-authorization/tsp-location.yaml Spec commit pointer update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/UsersOrServicePrincipalSetUserType.java New expandable enum model
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/UsersOrServicePrincipalSet.java Model type updated to new enum
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/CommonUserType.java Removed enum model
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/models/RoleAssignmentListResult.java Javadoc tweak
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/TenantLevelAccessReviewInstanceContactedReviewersClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewScheduleDefinitionsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewInstancesClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewInstanceOperationsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewInstanceDecisionsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewInstanceContactedReviewersClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewHistoryDefinitionsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewHistoryDefinitionOperationsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewHistoryDefinitionInstancesOperationsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewHistoryDefinitionInstancesClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ScopeAccessReviewDefaultSettingsClientImpl.java Regenerated client (scope encoding + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleManagementPolicyAssignmentsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleManagementPoliciesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleEligibilitySchedulesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleEligibilityScheduleRequestsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleEligibilityScheduleInstancesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleDefinitionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleAssignmentsClientImpl.java Regenerated client (api-version literal + signature reorder)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleAssignmentSchedulesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleAssignmentScheduleRequestsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleAssignmentScheduleInstancesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ProviderOperationsMetadatasClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/PermissionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/OperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/GlobalAdministratorsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/EligibleChildResourcesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/ClassicAdministratorsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AttributeNamespacesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AlertsClientImpl.java Regenerated client (expected responses + api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AlertOperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AlertIncidentsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AlertDefinitionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AlertConfigurationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewScheduleDefinitionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewScheduleDefinitionsAssignedForMyApprovalsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstancesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstancesAssignedForMyApprovalsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstanceOperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstanceMyDecisionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstanceDecisionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewInstanceContactedReviewersClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewHistoryDefinitionsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewHistoryDefinitionOperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewHistoryDefinitionInstancesOperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewHistoryDefinitionInstancesClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/AccessReviewDefaultSettingsOperationsClientImpl.java Regenerated client (api-version literal)
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewScheduleDefinitionsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewInstancesClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewInstanceOperationsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewInstanceDecisionsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewInstanceContactedReviewersClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewHistoryDefinitionsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewHistoryDefinitionOperationsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewHistoryDefinitionInstancesOperationsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewHistoryDefinitionInstancesClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/ScopeAccessReviewDefaultSettingsClient.java Javadoc param description update
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/RoleAssignmentsClient.java Javadoc return text tweak
sdk/authorization/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/fluent/AlertsClient.java LRO-related Javadoc tweaks
sdk/authorization/azure-resourcemanager-authorization/CHANGELOG.md Beta section updated (dated + entries)

Comment on lines +226 to +230
final String apiVersion = "undefined";
final String accept = "application/json";
return FluxUtil
.withContext(context -> service.get(this.client.getEndpoint(), apiVersion, scope, roleAssignmentName,
tenantId, accept, context))
.withContext(context -> service.get(this.client.getEndpoint(), apiVersion, scope, tenantId,
roleAssignmentName, accept, context))
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiVersion is being sent as the literal string "undefined" (e.g., in the api-version query param). This will cause every request using this client to fail server-side (invalid/missing api-version). Please ensure the generator emits the correct service API version(s) (per PR metadata: 2024-07-01-preview) instead of "undefined" and regenerate/fix across the module (this pattern appears in many client impls).

Copilot uses AI. Check for mistakes.
Comment on lines 20 to 56
@@ -42,7 +42,7 @@ public UsersOrServicePrincipalSet() {
*
* @return the type value.
*/
public CommonUserType type() {
public UsersOrServicePrincipalSetUserType type() {
return this.type;
}

@@ -52,7 +52,7 @@ public CommonUserType type() {
* @param type the type value to set.
* @return the UsersOrServicePrincipalSet object itself.
*/
public UsersOrServicePrincipalSet withType(CommonUserType type) {
public UsersOrServicePrincipalSet withType(UsersOrServicePrincipalSetUserType type) {
this.type = type;
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the public model type CommonUserType with UsersOrServicePrincipalSetUserType in the UsersOrServicePrincipalSet API surface. That is a breaking change for any consumers compiling against the previous beta; consider keeping CommonUserType as a deprecated alias/wrapper (or adding a migration note) and make sure the CHANGELOG includes this under “Breaking Changes”.

Copilot uses AI. Check for mistakes.
Comment on lines +3 to +14
## 2.54.0-beta.1 (2026-04-09)

### Features Added

### Breaking Changes

### Bugs Fixed
- Supported create and delete of "deny assignment".

### Other Changes

#### Dependency Updates

- Updated `api-version` to `2024-09-01-preview`.

Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG entry says the api-version was updated to 2024-09-01-preview, but the PR metadata indicates generation from 2024-07-01-preview, and the generated clients currently use "undefined" for apiVersion. Please align the CHANGELOG with the actual generated API version(s) and ensure the correct version is wired into the generated code before shipping.

Copilot uses AI. Check for mistakes.
Comment on lines +3 to +7
## 2.54.0-beta.1 (2026-04-09)

### Features Added

### Breaking Changes

### Bugs Fixed
- Supported create and delete of "deny assignment".
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top CHANGELOG section was converted from “(Unreleased)” to a dated release. Unless this PR is intended to finalize a release, the repo convention is to keep a single “(Unreleased)” section at the top and only date it when the version is actually released (e.g., sdk/core/azure-core/CHANGELOG.md keeps ## ... (Unreleased) at the top). Consider restoring “(Unreleased)” for 2.54.0-beta.1 until the release is cut.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants