Skip to content

chores(pop transform): standard snt init + R func docstrings - #118

Open
EstebanMontandon wants to merge 4 commits into
mainfrom
SNT25-659-pop-transformation
Open

chores(pop transform): standard snt init + R func docstrings#118
EstebanMontandon wants to merge 4 commits into
mainfrom
SNT25-659-pop-transformation

Conversation

@EstebanMontandon

Copy link
Copy Markdown
Collaborator

Second cleaning (no functional changes)

Scripts touched:
snt_dhis2_population_transformation.ipynb

.R files touched:
snt_dhis2_population_transformation.r

additionally unnecessary try: block was removed from the python pipeline snt_dhis2_population_transformation (no functional changes)

@sPuntinG sPuntinG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also great, seems all good!

Question -- just to double check : did you also test run all edited pipelines with their associated edited .ipynb and .r files?
(as needs to be done by hand because, as we know, the pull script mechanism only pull from main not from feature branches, it's easy to forget pieces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants