Skip to content

Fix island chat using team chat log setting and prefix#57

Merged
tastybento merged 2 commits into
developfrom
copilot/sub-pr-55
Apr 13, 2026
Merged

Fix island chat using team chat log setting and prefix#57
tastybento merged 2 commits into
developfrom
copilot/sub-pr-55

Conversation

Copilot AI commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

ChatListener.islandChat() was using isLogTeamChats() and logging [Team Chat Log], despite Settings already having a dedicated isLogIslandChats() field backed by island-chat.log in config. The island-chat logging tests reflected this bug, stubbing the wrong setting and asserting the wrong prefix.

Changes

  • ChatListener.java: islandChat() now calls isLogIslandChats() and logs [Island Chat Log]
  • ChatListenerTest.java: Island-chat logging tests updated to stub isLogIslandChats() and assert [Island Chat Log] prefix
// Before
if (addon.getSettings().isLogTeamChats()) {
    addon.log("[Team Chat Log] " + player.getName() + ": " + message);
}

// After
if (addon.getSettings().isLogIslandChats()) {
    addon.log("[Island Chat Log] " + player.getName() + ": " + message);
}

Copilot AI changed the title [WIP] [WIP] Address feedback from review on Release 1.4.0 Fix island chat using team chat log setting and prefix Apr 13, 2026
Copilot AI requested a review from tastybento April 13, 2026 06:53
@tastybento tastybento marked this pull request as ready for review April 13, 2026 07:13
@tastybento tastybento merged commit adc41b2 into develop Apr 13, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants