Update render-engine and adopt RedirectPage#913
Conversation
Bumps render-engine to 2026.5.2a1 and switches the five redirect pages (students, community, partnerships, leadership, pycon) to use the new RedirectPage class from render-engine/render-engine#1161 instead of hand-written meta-refresh HTML. Also fixes the students slug, which previously redirected to the non-existent /student-ambassadors-program.html. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These five files were the meta-refresh source for redirects now handled by RedirectPage in app.py — they were never referenced via content_path after the switch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
One more merge conflict 👀 |
|
@dragid10 - done |
Co-authored-by: Alex Oladele <dragid10@gmail.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
dragid10
left a comment
There was a problem hiding this comment.
Overall looks good, just had a question about dependency pinning going forward.
| "pyyaml", | ||
| "render-engine[cli]>=2026.5.2a1", | ||
| "render-engine-clean-urls==0.1.0", | ||
| "pyyaml==6.0.3", |
There was a problem hiding this comment.
Low Care Amount: Is pyyaml explicitly imported anywhere? If not, I'd probably not include it in the top-level packages. But if we are including it solve a CVE, then we could do pyyaml~=6.0 to always allow for patch version pickups.
There was a problem hiding this comment.
It is. IIRC we run deptry so all the items that are in the dependencies are directly called in the app.
There was a problem hiding this comment.
Medium Care Amount: I'm curious as to why we're pinning explicit versions. I mean I know that its definitely the most reproducible, but I feel like most of these could benefit from allowing patch versions to pick up vulnerability fixes in the future
There was a problem hiding this comment.
explicit versions is just based on historical presedent as render-engine ran into parser errors because we didn't explicitly pin our versions. FMI: render-engine/render-engine-markdown#9 (review)
There was a problem hiding this comment.
makes perfect sense. I do think a good medium path would still be adding constraints that aren't exact version pins, but that is a future consideration!
* update render-engine and adopt RedirectPage Bumps render-engine to 2026.5.2a1 and switches the five redirect pages (students, community, partnerships, leadership, pycon) to use the new RedirectPage class from render-engine/render-engine#1161 instead of hand-written meta-refresh HTML. Also fixes the students slug, which previously redirected to the non-existent /student-ambassadors-program.html. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * remove unused hand-written redirect HTML These five files were the meta-refresh source for redirects now handled by RedirectPage in app.py — they were never referenced via content_path after the switch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * lock * update broken links * Update pyproject.toml Co-authored-by: Alex Oladele <dragid10@gmail.com> * Update app.py Co-authored-by: Alex Oladele <dragid10@gmail.com> * Update app.py Co-authored-by: Alex Oladele <dragid10@gmail.com> * versions --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Alex Oladele <dragid10@gmail.com>
* add styling * update tests for toast * add corporate sponsorship page and change name (#912) * Update render-engine and adopt RedirectPage (#913) * update render-engine and adopt RedirectPage Bumps render-engine to 2026.5.2a1 and switches the five redirect pages (students, community, partnerships, leadership, pycon) to use the new RedirectPage class from render-engine/render-engine#1161 instead of hand-written meta-refresh HTML. Also fixes the students slug, which previously redirected to the non-existent /student-ambassadors-program.html. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * remove unused hand-written redirect HTML These five files were the meta-refresh source for redirects now handled by RedirectPage in app.py — they were never referenced via content_path after the switch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * lock * update broken links * Update pyproject.toml Co-authored-by: Alex Oladele <dragid10@gmail.com> * Update app.py Co-authored-by: Alex Oladele <dragid10@gmail.com> * Update app.py Co-authored-by: Alex Oladele <dragid10@gmail.com> * versions --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Alex Oladele <dragid10@gmail.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Alex Oladele <dragid10@gmail.com>
Summary
render-engineto2026.5.2a1(and pins the rest of the deps for reproducibility).students,community,partnerships,leadership,pycon) from hand-written meta-refresh HTML to the newRedirectPageclass introduced in Add support for page redirection. render-engine/render-engine#1161./studentstarget, which previously pointed at the non-existent/student-ambassadors-program.html(extras).Upstream reference
RedirectPage feature: render-engine/render-engine#1161
Test plan
uv syncresolves the new lockfile cleanlyuv run render-engine buildsucceedsoutput/pycon.html,output/community.html,output/partnerships.html,output/leadership.html,output/students.htmleach contain a<meta http-equiv="Refresh" ...>pointing at the expected target/studentsredirect lands on/student-ambassador-program.html(singular)🤖 Generated with Claude Code