Skip to content

Update render-engine and adopt RedirectPage#913

Merged
kjaymiller merged 9 commits into
gh-pagesfrom
update-render-engine
May 22, 2026
Merged

Update render-engine and adopt RedirectPage#913
kjaymiller merged 9 commits into
gh-pagesfrom
update-render-engine

Conversation

@kjaymiller
Copy link
Copy Markdown
Contributor

Summary

  • Bumps render-engine to 2026.5.2a1 (and pins the rest of the deps for reproducibility).
  • Switches the five redirect pages (students, community, partnerships, leadership, pycon) from hand-written meta-refresh HTML to the new RedirectPage class introduced in Add support for page redirection. render-engine/render-engine#1161.
  • Deletes the now-unused root HTML files that used to back those redirects.
  • Fixes the /students target, which previously pointed at the non-existent /student-ambassadors-program.html (extra s).
  • Footer: drop the Partnerships/Community links, add a Students Ambassador Program link.

Upstream reference

RedirectPage feature: render-engine/render-engine#1161

Test plan

  • uv sync resolves the new lockfile cleanly
  • uv run render-engine build succeeds
  • output/pycon.html, output/community.html, output/partnerships.html, output/leadership.html, output/students.html each contain a <meta http-equiv="Refresh" ...> pointing at the expected target
  • /students redirect lands on /student-ambassador-program.html (singular)
  • Footer renders the new Students Ambassador Program link

🤖 Generated with Claude Code

kjaymiller and others added 2 commits May 20, 2026 17:12
Bumps render-engine to 2026.5.2a1 and switches the five redirect pages
(students, community, partnerships, leadership, pycon) to use the new
RedirectPage class from render-engine/render-engine#1161 instead of
hand-written meta-refresh HTML.

Also fixes the students slug, which previously redirected to the
non-existent /student-ambassadors-program.html.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These five files were the meta-refresh source for redirects now handled
by RedirectPage in app.py — they were never referenced via content_path
after the switch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kjaymiller kjaymiller requested review from dragid10 and lazouich May 21, 2026 01:15
@dragid10
Copy link
Copy Markdown
Member

One more merge conflict 👀

@kjaymiller
Copy link
Copy Markdown
Contributor Author

@dragid10 - done

@kjaymiller
Copy link
Copy Markdown
Contributor Author

@dragid10 the failing test is for the redirect test logic which is corrected in #914

Comment thread app.py Outdated
Comment thread pyproject.toml Outdated
Comment thread app.py
kjaymiller and others added 3 commits May 21, 2026 18:25
Co-authored-by: Alex Oladele <dragid10@gmail.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
@kjaymiller kjaymiller requested a review from dragid10 May 22, 2026 01:26
Copy link
Copy Markdown
Member

@dragid10 dragid10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just had a question about dependency pinning going forward.

Comment thread pyproject.toml
"pyyaml",
"render-engine[cli]>=2026.5.2a1",
"render-engine-clean-urls==0.1.0",
"pyyaml==6.0.3",
Copy link
Copy Markdown
Member

@dragid10 dragid10 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low Care Amount: Is pyyaml explicitly imported anywhere? If not, I'd probably not include it in the top-level packages. But if we are including it solve a CVE, then we could do pyyaml~=6.0 to always allow for patch version pickups.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. IIRC we run deptry so all the items that are in the dependencies are directly called in the app.

Comment thread pyproject.toml
Copy link
Copy Markdown
Member

@dragid10 dragid10 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium Care Amount: I'm curious as to why we're pinning explicit versions. I mean I know that its definitely the most reproducible, but I feel like most of these could benefit from allowing patch versions to pick up vulnerability fixes in the future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit versions is just based on historical presedent as render-engine ran into parser errors because we didn't explicitly pin our versions. FMI: render-engine/render-engine-markdown#9 (review)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes perfect sense. I do think a good medium path would still be adding constraints that aren't exact version pins, but that is a future consideration!

@kjaymiller kjaymiller merged commit 2a7f3c2 into gh-pages May 22, 2026
5 of 6 checks passed
@kjaymiller kjaymiller deleted the update-render-engine branch May 22, 2026 16:09
kjaymiller added a commit that referenced this pull request May 22, 2026
* update render-engine and adopt RedirectPage

Bumps render-engine to 2026.5.2a1 and switches the five redirect pages
(students, community, partnerships, leadership, pycon) to use the new
RedirectPage class from render-engine/render-engine#1161 instead of
hand-written meta-refresh HTML.

Also fixes the students slug, which previously redirected to the
non-existent /student-ambassadors-program.html.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* remove unused hand-written redirect HTML

These five files were the meta-refresh source for redirects now handled
by RedirectPage in app.py — they were never referenced via content_path
after the switch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* lock

* update broken links

* Update pyproject.toml

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* versions

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
kjaymiller added a commit that referenced this pull request May 22, 2026
* add styling

* update tests for toast

* add corporate sponsorship page and change name (#912)

* Update render-engine and adopt RedirectPage (#913)

* update render-engine and adopt RedirectPage

Bumps render-engine to 2026.5.2a1 and switches the five redirect pages
(students, community, partnerships, leadership, pycon) to use the new
RedirectPage class from render-engine/render-engine#1161 instead of
hand-written meta-refresh HTML.

Also fixes the students slug, which previously redirected to the
non-existent /student-ambassadors-program.html.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* remove unused hand-written redirect HTML

These five files were the meta-refresh source for redirects now handled
by RedirectPage in app.py — they were never referenced via content_path
after the switch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* lock

* update broken links

* Update pyproject.toml

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* versions

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants