parity(dax): fix all parity.md findings#2363
Closed
agbishop wants to merge 6 commits into
Closed
Conversation
…ror mapping - IncreaseReplicationFactor: guard used raw loop index i instead of offset j=i-existingCount, silently ignoring caller-supplied AZs when the cluster already had nodes - RebootNode: empty NodeId returned ErrNodeNotFound; AWS returns InvalidParameterValue. Add recovery goroutine that restores node status to available after 1s, mirroring real DAX behaviour - UpdateParameterGroup: did not mark dependent clusters pending-reboot or populate NodeIDsToReboot; now scans all clusters using the group - writeBackendError: flattened every DynamoDB error to ValidationException; now maps ConditionalCheckFailed, ResourceNotFound, TransactionCanceled, TransactionConflict, and ProvisionedThroughputExceeded to their correct DAX error codes - handleGetItem: decoded ConsistentRead from the wire but discarded it with _; now passes it through to the DynamoDB backend - nameRef: O(n²) linear scan replaced with O(1) reverse map - schemaFor: cache was never invalidated on table drop/recreate; now fetches live on every call for correctness Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Executed-By: gopherstack/polecats/amber
Collaborator
Author
📊 Code Coverage Report
Tip This project maintains a minimum coverage threshold of 85%. Maintain or improve coverage on new code to ensure long-term stability. Last updated: Fri, 26 Jun 2026 00:04:26 GMT |
…utes GetQueueAttributes read q.messages, q.delayedCount, and q.inFlightMessages without holding q.mu, while ReceiveMessage writes them under q.mu.Lock. This caused a data race detected by -race in TestIntegration_Lambda_SQS_ESM. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Folded into parity-sweep #2342 (single accumulating PR per workflow) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAX parity. Validated unit + scoped integration. GH006-safe PR.
🤖 Generated with Claude Code