refactor(poller): resilient dual-stack map generation

[somethingwithproof]

Summary

The poller now loads the Device set once and publishes resilient dual-stack snapshots:

• one Device query per cycle, with every region rendered from that shared set
• literal IPv4/IPv6 support and filename-safe /16, /32, /48 IPv6 drill-down
• no synchronous DNS on the poller path; a separate worker refreshes a persistent last-known-good cache
• optional thold integration marks otherwise-up Devices with active thresholds as alert and uses their Down icon
• atomic artefact writes plus age-based pruning after three poller intervals, only after a successful Device query
• deterministic schema upgrades, aligned icon validation, and removal of the unused tower endpoint

Issue coverage and overlap

This PR is the single implementation PR for the related poller concerns. No separate PR duplicates these changes:

• Closes Update subnet's on a cycle instead of every polling cycle #6 — repeated Device loads and DNS work
• Closes IPv6-only Devices are silently dropped from the map #104 — IPv6 Devices and dual-stack drill-down
• Closes Blocking DNS resolution on the poller critical path #107 — blocking DNS on the poller path
• Closes Markers ignore thold state, so an alarming Device looks healthy #109 — optional thold-aware marker state
• Closes Generated artefacts are never removed, and cycle-based pruning is unsafe #110 — safe age-based generated artefact pruning

PR #102 changes workflows only and does not overlap these runtime changes.

Linux Docker validation

• PHP 8.0 lint: every plugin PHP file passes (vendor excluded)
• standalone suite: 281 tests, 0 failures
• Xdebug coverage: 504/504 executable lines, 100%
• PHP CS Fixer: all 15 changed PHP files clean
• git diff --check: clean

The repository has no composer.json; none was created or edited.

[Copilot]

Pull request overview

Refactors the gpsmap poller workflow to load the mapped Device set once per poller cycle and reuse it across subnet renders, significantly reducing repeated DB queries and DNS lookups. It also hardens upgrade/version persistence behavior, makes artefact publication behavior explicit on failure vs empty estates, improves atomic artefact writes, and unifies icon validation between the UI dropdown and the renderers.

Changes:

• Split region processing into gpsmap_load_devices() (single load) and gpsmap_render_region() (per-subnet render), with prefix enumeration derived from already-resolved addresses.
• Add/extend tests and coverage targets for polling + upgrade behavior, and add new upgrade-path regression tests.
• Move/centralize icon enumeration logic into gpsmap_security.php and align it with renderer constraints.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/test_upgrade.php	New regression tests for upgrade gating, version persistence, and backoff behavior.
tests/test_polling.php	Adds tests for single-pass loading, atomic writes, publication decisions, and direct poller entry point coverage.
tests/test_icons.php	Adds tests ensuring getIcons() matches renderer constraints and respects base_path.
tests/run.php	Adds test_upgrade.php to the test runner.
tests/harness.php	Ensures test tmp root symlinks include additional plugin entrypoints needed by new tests.
tests/coverage.php	Expands coverage gate to include polling + upgrade logic; removes deleted entry point mention.
setup.php	Passes persisted old-version into gpsmap_upgrade_database() instead of relying on an unset global.
print.php	Clarifies authentication control flow in comment.
includes/towerSelect.php	Removes unused/unreferenced legacy entry point.
includes/setup/database.php	Makes upgrade path deterministic (version persisted, retry backoff, schema verification) and adjusts table create details.
includes/polling/processregion.php	Introduces load/render split, prefix derivation, and device state reset between renders.
includes/polling/functions.php	Makes artefact writes staged+atomic while preserving destination file mode.
includes/polling.php	Refactors poller entry to single-load per cycle + explicit publish/withhold decisions and stats logging.
gpstemplates.php	Uses shared getIcons() (now in gpsmap_security.php) and escapes edit URL.
gpsmap_security.php	Adds getIcons() implementation consistent with renderer constraints and base_path.
.gitignore	Ignores local debug file under tests.

Suppressed comments (1)

tests/test_polling.php:341

• This base_path override is immediately restored without any assertion or code that depends on it, so it has no effect (and can confuse future readers). It should be removed or turned into a real assertion.

$savedRoot = $GLOBALS['config']['base_path'];
$GLOBALS['config']['base_path'] = $root . '/no-such-root';
$GLOBALS['config']['base_path'] = $savedRoot;

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[TheWitness]

CI is not working.

[TheWitness]

Superseded by #121, which ports these changes onto the Cacti repo directly (resolving the merge conflicts from the CI harmonization work in #119/#120) so they can be reviewed and merged. All credit for the implementation remains with @somethingwithproof — thank you for the contribution!