Skip to content

Fix/mooclet priors#3089

Closed
danoswaltCL wants to merge 11 commits intodevfrom
fix/mooclet-priors
Closed

Fix/mooclet priors#3089
danoswaltCL wants to merge 11 commits intodevfrom
fix/mooclet-priors

Conversation

@danoswaltCL
Copy link
Copy Markdown
Collaborator

@danoswaltCL danoswaltCL commented Apr 24, 2026

Apologies for giant PR, i got carried away

  • Adds a proper entry for priors per condition in the design page
  • Removes priors from overview and upsert experiment modal
  • Adds Reward Feedback Table improvements to show count, priors, posteriors, and estimated weight
  • Estimated weight is a new feature itself, the language of the tooltip explains it:
    --
Screenshot 2026-04-24 at 5 16 59 PM -- Screenshot 2026-04-24 at 5 17 25 PM

--

Screenshot 2026-04-24 at 5 17 56 PM -- Screenshot 2026-04-24 at 5 18 10 PM -- Screenshot 2026-04-24 at 5 18 23 PM -- Screenshot 2026-04-24 at 5 20 31 PM

--
Screenshot 2026-04-24 at 5 21 38 PM

--

@danoswaltCL danoswaltCL requested review from bcb37, Copilot and zackcl and removed request for bcb37 and Copilot April 27, 2026 16:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR shifts Thompson-sampling priors from a single global setting to per-condition priors, updates the experiment design UI accordingly, and enhances the reward feedback table to display priors/posteriors plus an “estimated weight” metric computed via Thompson-sampling simulation.

Changes:

  • Add per-condition prior editing via a new modal and wire it into the experiment conditions table/section.
  • Revamp the TS reward feedback table to show counts, priors, posteriors, and an estimated weight with explanatory tooltips.
  • Backend/types updates to support per-condition priors and to return additional reward-summary fields used by the UI.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
packages/types/src/index.ts Re-export Prior / CurrentPosteriors from the types package.
packages/types/src/Mooclet/index.ts Extend rewards summary shape (add priors/posteriors/estimated weight fields; remove total).
packages/types/src/Mooclet/MoocletTSConfigurablePolicyParametersDTO.ts Change prior to an optional per-key map (Record<string, Prior>).
packages/frontend/projects/upgrade/src/assets/i18n/en.json Add new labels/tooltips for prior editing + estimated weight columns.
packages/frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts Add dialog opener for the new “edit condition prior” modal.
packages/frontend/projects/upgrade/src/app/features/.../ts-configurable-reward-count-table.component.ts Add estimated-weight tooltip logic + new displayed columns.
packages/frontend/projects/upgrade/src/app/features/.../ts-configurable-reward-count-table.component.html Update reward table columns to show priors/posteriors and estimated weight tooltips.
packages/frontend/projects/upgrade/src/app/features/.../ts-configurable-reward-count-table.component.scss Update reward table column sizing/styling for new columns.
packages/frontend/projects/upgrade/src/app/features/.../enrollment-condition-expandable-row.component.{html,scss} Hide “weight” column content for Mooclet experiments in enrollment expandable row.
packages/frontend/projects/upgrade/src/app/features/.../experiment-conditions-table.component.ts Add prior input + columns/events for prior display/edit.
packages/frontend/projects/upgrade/src/app/features/.../experiment-conditions-table.component.html Render prior successes/failures columns and add an edit-prior button.
packages/frontend/projects/upgrade/src/app/features/.../experiment-conditions-table.component.scss Add styling for prior/prior-edit columns.
packages/frontend/projects/upgrade/src/app/features/.../experiment-conditions-section-card.component.ts Wire prior-edit event to dialog + store update.
packages/frontend/projects/upgrade/src/app/features/.../experiment-conditions-section-card.component.html Pass priors into the conditions table and bind edit-prior output.
packages/frontend/projects/upgrade/src/app/features/.../ts-configurable-policy-parameters-form.component.{ts,html} Remove global prior inputs from the experiment upsert modal form.
packages/frontend/projects/upgrade/src/app/features/.../edit-condition-prior-modal/* New modal implementation for editing per-condition priors.
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts Remove prior labels from TS-configurable overview labels.
packages/frontend/projects/upgrade/src/app/core/experiments/mooclet-helper.service.ts Remove global prior handling; add validators for per-condition prior inputs.
packages/frontend/projects/upgrade/src/app/core/experiments/mooclet-helper.service.spec.ts Update tests to reflect removal of global prior fields in helper logic.
packages/frontend/projects/upgrade/src/app/core/experiments/experiments.service.ts Add store update helper for per-condition priors.
packages/backend/src/api/services/estimate.ts New Thompson-weight estimation helper (currently unused).
packages/backend/src/api/services/MoocletRewardsService.ts Fetch policy params and include priors/posteriors/estimated weight in rewards summary response.
packages/backend/src/api/services/MoocletExperimentService.ts Translate prior keys between condition codes and Mooclet version IDs on GET/PUT.
packages/backend/test/unit/services/MoocletRewardsService.test.ts Update expected reward summary shape for the new fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/backend/src/api/services/MoocletRewardsService.ts
Comment thread packages/backend/src/api/services/MoocletRewardsService.ts
Comment thread packages/backend/src/api/services/estimate.ts Outdated
Comment thread packages/backend/src/api/services/MoocletRewardsService.ts
Comment thread packages/backend/src/api/services/estimate.ts Outdated
@danoswaltCL danoswaltCL requested a review from bcb37 April 28, 2026 19:33
@danoswaltCL
Copy link
Copy Markdown
Collaborator Author

#3093 is the new one

@danoswaltCL danoswaltCL reopened this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants