parrallel get flag from context#3192
Open
danoswaltCL wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors FeatureFlagRepository.getFlagsFromContext() to reduce query cost by splitting the previous large left-join query into separate, parallelized queries keyed by filterMode, avoiding cross-join/cartesian blowups when segment relations contain multiple rows.
Changes:
- Split
getFlagsFromContext()into two parallel queries (INCLUDE_ALLandEXCLUDE_ALL) and removed inclusion-joins forINCLUDE_ALLflags. - Introduced small query-builder helper functions to share base conditions/joins across both queries.
- Added unit tests to validate query structure, join behavior, and result merging/error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/backend/src/api/repositories/FeatureFlagRepository.ts | Refactors getFlagsFromContext() into two parallel queries and conditionally applies joins to reduce cartesian explosion risk. |
| packages/backend/test/unit/repositories/FeatureFlagRepository.test.ts | Adds unit coverage for the new query-splitting behavior and join expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+183
to
+185
| beforeEach(() => { | ||
| mock.getMany.mockResolvedValue([]); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks up the primary feature-flag fetcher
getFlagsFromContext()into 3 parallel calls, instead of a 10 left-joiner, which apparently is another 'Cartesian Product' combinatorial explosion if several joins have several rows returned.It also avoids getting inclusion lists at all when INCLUDE_ALL.
With a prod snapshot restored in my local, when i get flags for a user in
clccontext, this fetches in a tenth of the speed (~80ms vs 800ms).