Repository navigation
Merge/release 6.7 into dev - #3404
Merged
Merged
Conversation
* python clientlib: add context to mark calls * update request type
…ata can be mapped to perfdiag logs
…id-to-nr-tags add instanceId that perfdiag uses to new relic data so per-instance d…
# Conflicts: # packages/backend/cl.Dockerfile
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow telemetry change reuses existing helpers without altering request behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Adds the backend process identifier to New Relic telemetry for client-SDK requests, allowing transactions to be correlated with performance diagnostic logs.
Changes:
- Reuses
getInstanceId()to attach aninstanceIdcustom attribute inClientContextMiddleware. - Leaves existing client context attributes and request flow unchanged.
| File | Description |
|---|---|
packages/backend/src/api/middlewares/ClientContextMiddleware.ts |
Adds the process identifier to client-request telemetry. |
Review effort: Balanced
bcb37
reviewed
Oct 27, 2026
bcb37
left a comment
bcb37
left a comment
Collaborator
There was a problem hiding this comment.
The node image update shouldn't be merged back to dev, since dev is on node 26. Not sure if it will overwrite that.
Collaborator
Author
|
it shouldn't, the diff doesn't show that, it's just the one file. |
bcb37
self-requested a review
October 28, 2026 15:09
bcb37
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i don't know why these extra commits show up but this is just merging down the
instanceIdnew relic custom attribute commit.