[ENG-11380] Project Overview Page UI Improvements#1014
Conversation
nsemets
changed the base branch from
feature/pbs-26-9
to
feature/my-projects-improvements
| readonly isButtonDisabled = computed( | ||
| () => this.isFilesLoading() || this.isStorageLoading() || this.filesTotalCount() === 0 | ||
| ); |
There was a problem hiding this comment.
As per the acceptance criteria of ticket, the Download as Zip option should be visible to logged-in admins only. Currently isButtonDisabled only guards on loading state and file count, so the button renders for all users (contributors, read-only members, etc.). Need to add an admin/write-access check here, e.g. pulling hasWriteAccess or an isAdmin selector and including it in the computed and also wrap the button in an @if in the template so non-admins don't see it at all.
There was a problem hiding this comment.
This needs to be clarified because, on the Files page, downloading is available for any user.
There was a problem hiding this comment.
@omar-cos The requirements should be updated, and the "Download as ZIP" option should be available to all users.
There was a problem hiding this comment.
Mark has updated the requirements, and I updated the acceptance criteria of the ticket to match.
brianjgeiger
merged commit a89a119
into
CenterForOpenScience:feature/my-projects-improvements
3 participants
Summary of Changes
Screenshot(s)