Skip to content

Trigger Tableau TDVT in connectors on snapshot publish and release (CON-264) #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShimonSte wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Trigger Tableau TDVT in connectors on snapshot publish and release (CON-264) #2875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,20 @@ jobs:
gpg_passphrase: ${{ secrets.GPG_PASSPHRASE }}
nexus_username: ${{ secrets.SONATYPE_TOKEN_USER }}
nexus_password: ${{ secrets.SONATYPE_TOKEN }}
# Tableau users install the latest JDBC driver manually, so a snapshot
# regression hits them with no connector release in between - trigger the
# TDVT suite in ClickHouse/connectors on every published snapshot.
# https://github.com/ClickHouse/connectors/issues/71
- name: Trigger Tableau TDVT in connectors
if: success()
continue-on-error: true # a TDVT dispatch failure must never fail the publish
env:
GH_TOKEN: ${{ secrets.CONNECTORS_DISPATCH_TOKEN }}
run: |
# The published snapshot version is the pom's <revision> property
# (env.CHC_VERSION is commented out above, so it can't be used here)
VERSION=$(sed -n 's|.*<revision>\(.*\)</revision>.*|\1|p' pom.xml | head -1)
echo "Dispatching TDVT for clickhouse-jdbc $VERSION"
gh api repos/ClickHouse/connectors/dispatches \
-f event_type=jdbc-snapshot \
-F "client_payload[jdbc_version]=$VERSION"
14 changes: 14 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,17 @@ jobs:
clickhouse-r2dbc/target/clickhouse*.jar
client-v2/target/client-v2*.jar
jdbc-v2/target/jdbc-v2*.jar
# Tableau users install the latest JDBC driver manually, so a release

@chernser chernser Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release workflow does only push to staging and library may not be accessible for some time after that.
I think, we need somehow grab latest from maven central and test every week.

Idea is:

  • if something broken - we should catch it on nightly
  • if we doing a release and it is a release candidate - then latest should catch but actually we may trigger tests earlier.

# regression hits them with no connector release in between - trigger the
# TDVT suite in ClickHouse/connectors on every release.
# https://github.com/ClickHouse/connectors/issues/71
- name: Trigger Tableau TDVT in connectors
if: success()
continue-on-error: true # a TDVT dispatch failure must never fail the release
env:
GH_TOKEN: ${{ secrets.CONNECTORS_DISPATCH_TOKEN }}
run: |
echo "Dispatching TDVT for clickhouse-jdbc ${{ github.event.inputs.version }}"
gh api repos/ClickHouse/connectors/dispatches \
-f event_type=jdbc-release \
-F "client_payload[jdbc_version]=${{ github.event.inputs.version }}"
Loading