Revert "Redesign homepage below-hero sections"#151
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3e69303. Configure here.
| const darkFilename = darkFilenameProp || (filename ? filename.replace('-light.', '-dark.') : null); | ||
| const cardClassName = `ch-hero-card ${arrowBottom ? 'flex flex-col' : 'block'} p-4 rounded-lg no-underline bg-[#f9f9f9] border border-[#e5e7eb]`; | ||
|
|
||
| const cardClassName = "ch-hero-card block p-4 rounded-lg no-underline bg-[#f9f9f9] border border-[#e5e7eb]"; |
There was a problem hiding this comment.
Dark mode hero cards broken
Medium Severity
The revert drops .dark .ch-hero-card rules from _site/styles.css, but English HeroCard still uses the ch-hero-card class with light-only Tailwind (bg-[#f9f9f9], border-[#e5e7eb]) and no dark: variants, so goal, use case, and product cards stay light-themed in dark mode.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3e69303. Configure here.
| <h2 className="text-2xl font-semibold text-gray-900 dark:text-zinc-50 mb-0">Set up docs MCP server</h2> | ||
| <p className="text-sm text-gray-500 dark:text-zinc-500" style={{ marginBottom: '24px' }}>Query the ClickHouse documentation directly from your AI tools using the Model Context Protocol.</p> | ||
| <div style={{ marginTop: '24px' }}><McpSetup /></div> | ||
| <div id="mcp-setup" style={{ marginTop: '64px', paddingTop: '40px', borderTop: '1px solid rgba(255,255,255,0.08)', scrollMarginTop: '80px' }}> |
There was a problem hiding this comment.
MCP divider invisible light mode
Low Severity
The MCP section wrapper uses a fixed borderTop of rgba(255,255,255,0.08), which is barely visible on the light theme and removes the visual separator that existed without that border in the redesigned layout.
Reviewed by Cursor Bugbot for commit 3e69303. Configure here.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
1 participant
Reverts #149
Note
Low Risk
Documentation-only homepage MDX and static CSS; no backend or auth changes. Main risk is visual/regression on localized home pages and any reliance on the removed asymmetric product layout.
Overview
This reverts the homepage below-hero redesign (PR #149) across the main and localized home
index.mdxfiles and built_site/styles.css.HeroCardand layout: RemovesFullWidthDividerand trimsHeroCardprops (body,showArrow,arrowBottom,extraStyle). Use-case and product cards drop corner arrows and full-bleed dividers; sections use simpler stacked headings and uniform grids instead of intro copy plusFullWidthDividerbreaks.English homepage (
index.mdx): Replaces the asymmetric product layout (large ClickHouse Cloud card with inline link lists plus a side column) with a flat 3-column grid of image cards. Restores use-case hero images on all four cards. Tweaks the docs MCP block spacing (top border / padding). Fixes switcher mode so the “Explore by use case” title shows when that tab is selected.Locale copies (
es,ja,ko, etc.): Same structural simplification; localeHeroCardlinks drop thepreventDefault+window.locationhack in favor of normal<a href>.CSS: Deletes
.ch-hero-cardhover/dark rules,.ch-usecase-divider, and.ch-usecase-arrowfrom_site/styles.css(the English page still uses thech-hero-cardclass with Tailwind utilities only).Reviewed by Cursor Bugbot for commit 3e69303. Bugbot is set up for automated code reviews on this repo. Configure here.