feat: implement a method to delete a directory from a template.#1199
Open
GiantTreeLP wants to merge 3 commits into
Open
feat: implement a method to delete a directory from a template.#1199GiantTreeLP wants to merge 3 commits into
GiantTreeLP wants to merge 3 commits into
Conversation
GiantTreeLP
force-pushed
the
1198-delete-directories-in-templates
branch
2 times, most recently
from
April 15, 2023 22:58
a6da5fe to
72328b0
Compare
GiantTreeLP
force-pushed
the
1198-delete-directories-in-templates
branch
from
April 30, 2023 20:25
72328b0 to
785e4a6
Compare
GiantTreeLP
force-pushed
the
1198-delete-directories-in-templates
branch
from
May 8, 2023 12:18
56b9a3f to
83b3b96
Compare
GiantTreeLP
force-pushed
the
1198-delete-directories-in-templates
branch
from
July 9, 2023 15:13
83b3b96 to
efd9cbd
Compare
GiantTreeLP
marked this pull request as ready for review
July 9, 2023 15:34
This change allows developers to directly delete a directory and all its containing files and directories from a given service template. As an additional functionality, this method is also exposed to the HTTP Rest API much like the file deletion method already is.
…es from templates.
GiantTreeLP
force-pushed
the
1198-delete-directories-in-templates
branch
from
October 2, 2023 21:50
c9bd3e6 to
154ac82
Compare
0xIO32
approved these changes
Nov 8, 2023
0xIO32
left a comment
0xIO32
left a comment
Contributor
There was a problem hiding this comment.
Github said "At least 1 approving review is required to merge this pull request.", so i made one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See #1198.
Modification
This change allows developers to directly delete a directory and all its containing files and directories from a given service template.
As an additional functionality, this method is also exposed to the HTTP Rest API much like the file deletion method already is.
Result
Developers can now delete entire directory trees from a given template.
Other context
Closes #1198.
Local template storage has already been tested on my machine, I will check whether SFTP and S3 storage can be tested. If not, I may seek help from your end.