changed default email to noreply c4c email since its verified#434
Open
changed default email to noreply c4c email since its verified#434
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the backend’s fallback SES sender address to use the verified noreply@c4cneu.com account when NOTIFICATION_EMAIL_SENDER is not set. It affects both the general notification email flow and the user verification email flow.
Changes:
- Replaces the fallback sender in
NotificationService.sendEmailNotification. - Replaces the fallback sender in
UserService.sendVerificationEmail. - Standardizes both email-sending paths on the same default sender address.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
backend/src/user/user.service.ts |
Updates the fallback sender used for account approval emails. |
backend/src/notifications/notification.service.ts |
Updates the fallback sender used for general notification emails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes nothing
📝 Description
changed it so email needs to be defined in env to send emails
also removed duplicate send email method
Add NOTIFICATION_EMAIL_SENDER='noreply@c4cneu.com' to env to have correct email!