automated email user updates#167
Open
swarkewalia wants to merge 3 commits intomainfrom
Open
Conversation
sam-schu
requested changes
Apr 30, 2026
Collaborator
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
Can we wrap the email sending in a try-catch like we do for the other emails?
dburkhart07
requested changes
May 3, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
See slack comment about the rest of the ticket. Also, I wonder if we should alter the email to include which pantries the volunteer has been assigned to. Can we ask Priya about that?
| return this.repo.save(volunteer); | ||
| const saved = await this.repo.save(volunteer); | ||
|
|
||
| const { subject, bodyHTML } = |
There was a problem hiding this comment.
Can we add tests for this functionality like we've done for all of the other emails?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes 189
📝 Description
Implemented Volunteer’s pantry assignment change automated email template
✔️ Verification
BEFORE TESTING: Add 2 new environment variables:
AWS_SES_SENDER_EMAIL (set this to one of your emails, this will be the address that sends the emails for you to verify)
SEND_AUTOMATED_EMAILS (switch this to true to turn on Cognito account creation and email sending permissions)
Add your email that you put in the AWS_SES_SENDER_EMAIL into the following AWS SES Identities: https://us-east-2.console.aws.amazon.com/ses/home?region=us-east-2#/identities
Reference #127
Update a volunteer's pantry assignment PATCH /api/pantries/{pantryId}/volunteers (through a secondary email while primary is admin) and verify that the proper sender, subject, message, attachments are all there.