fix(rules): anchor system var tmp paths - #93
Conversation
The recursive var/tmp glob also matched user projects and Homebrew state, exposing them as actionable temporary files. Restrict the rule to the Linux and macOS system roots and pin both intended and excluded paths in tests.
Muawiya-contact
left a comment
There was a problem hiding this comment.
This one's spot on. Mirroring unix-system-logs is the right shape, and you covered all four cases from the issue plus the macOS path. Rebased and ran it here: fmt, clippy and 57 tests all clean.
Only outstanding thing is the changelog line, same as the other two.
|
Merged current main and moved the changelog entry to Unreleased. |
Muawiya-contact
left a comment
There was a problem hiding this comment.
Changelog's in the right place now, and the rule itself was already right. Ran it here: fmt, clippy and all tests pass.
There's a small conflict on CHANGELOG.md — #92 landed a ### Fixed bullet on the same line yours goes on. Nothing for you to do, both lines just want keeping and I'll sort it on merge. Everything else auto-merges clean, and I checked the combined result builds and passes.
Approved.
Signed-off-by: Muawiya Amir <contactmuawia@gmail.com>
Fixes #81.
What & why
Anchors the actionable
var/tmprule to Linux/var/tmpand macOS/private/var/tmp. User, project, and Homebrewvar/tmppaths now remain unknown instead of being offered for quarantine.Checklist
cargo fmt --alland strict clippy pass fordiskern-coreanddiskern-cli