Skip to content

Fix Android profile photo preparation after v1.10.17 - #477

Merged
Muawiya-contact merged 2 commits into
developfrom
codex/fix-native-photo-upload
Nov 2, 2026
Merged

Muawiya-contact merged 2 commits into
developfrom
codex/fix-native-photo-upload

Conversation

@Muawiya-contact

Copy link
Copy Markdown
Member

What changed

  • Requests JPEG bytes from Expo ImagePicker for gallery and camera photos. A valid result under 5 MB can be saved without invoking the image converter.
  • For larger or non-JPEG picker results, uses Expo ImageManipulator's Base64 JPEG output. Both paths verify the JPEG signature and size before uploading binary bytes. This removes the Android fetch(file://) and React Native Blob/FileReader bridge that still produced the local preparation error in v1.10.17.
  • Keeps the existing avatar untouched if preparation or upload fails. No backend, database, or native dependency changes.

Verification

  • Mobile TypeScript passed.
  • Focused photo preparation tests passed (3 tests), including exact binary bytes, direct picker output, and invalid/oversized output.
  • Expo web export passed. Browser gallery/camera, upload recovery, and compact profile smoke test passed in light and dark themes.
  • Full local npm test reached the existing publicConfig subprocess assertion, which cannot spawn Node in this sandbox (EPERM). Hosted CI is the authoritative full-suite check.

Remaining verification

  • The Android device path must be checked on the preview app after this PR merges. This PR does not publish a production update.

Follow-up to closed issue #457 after the owner's v1.10.17 device report.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-02T13:45:09.747007Z
We couldn’t complete this review. Comment @codex review to try again.
4caebc2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Muawiya-contact
Muawiya-contact merged commit 2924c81 into develop Nov 2, 2026
4 checks passed
@Muawiya-contact
Muawiya-contact deleted the codex/fix-native-photo-upload branch November 2, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant