Skip to content

chore: sync vendored Comfy Router spec (cloud@90a81a4b) - #222

Merged
wei-hai merged 2 commits into
mainfrom
chore/sync-router-spec
Oct 22, 2026
Merged

wei-hai merged 2 commits into
mainfrom
chore/sync-router-spec

Conversation

@cloud-code-bot

@cloud-code-bot cloud-code-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

This updates the SDK's local copy of the Router service's published contract. The new contract adds no new kinds of error, so no error classes change. One test is adjusted so it keeps checking the right thing now that the model-list route also accepts an optional caching header.

Automated sync of the public Comfy Router spec, projected from the canonical contract (internal notes stripped). Source: cloud@90a81a4b.

It lands at spec/router-openapi.yaml and is a contract of its own — it is never merged into another vendored spec in this repo.

This is the single rolling sync pull request for spec/router-openapi.yaml. It lives
on chore/sync-router-spec, and every later change to the upstream contract
force-updates this same branch and refreshes this description with the
new source commit — so there is only ever one open sync PR for this
spec, and its diff is always the current one.

The error-type class commit described above is the one commit that
belongs here. Once a commit of yours is on this branch, the next sync
refuses to force-update it and fails, naming this pull request, so
land this pull request promptly. Push any other follow-up work to a
branch of your own.

No Router operations are currently unserved (as of cloud@90a81a4b).

This note auto-refreshes while this PR is open: a change to comfy-api's
exclude list rewrites this section in place, and a change to the
PUBLISHED Router surface opens its own sync PR carrying the set as of
ITS commit. Once this PR is merged the note is a permanent snapshot —
for the current state, check services/comfy-api/drip/codegen.yaml in
Comfy-Org/cloud directly.

No code generation for this spec yet. Nothing in this repo
generates code from spec/router-openapi.yaml, so this sync has no low layer to
regenerate and the workflow that opened this pull request could not
prepare one for you.

That is not the same as nothing to do. This repo keeps a hand-written
surface coupled to this contract — its error-type class table — with
a drift check of its own, so a sync that adds an error bucket still
needs a commit here before this pull request goes green. When code
generation does land for this spec, its command is configured
upstream, in the same sync workflow that opened this PR, and this
section becomes the automatic one.

Commit that class to this branch and land this pull request once it
is green. The class cannot land separately: the drift check also
fails on a class the vendored spec does not declare yet. Your commit
is safe here — the next sync will not overwrite it; it fails instead,
naming this pull request — but every later sync for this spec stays
paused until this pull request is merged (which deletes the branch,
so the following sync starts fresh), or closed and its branch
deleted.

Commits on this branch beyond the sync

  • test(router): read only query parameters off the catalog route: the sync adds an optional If-None-Match header parameter to GET /v2/models. The catalog contract test collected every parameter regardless of location, so it now checks only the query parameters (cursor, limit) and also asserts that every non-query parameter stays optional, because models.list() never sends one. This sync adds no new Router error type, so no error-type class commit is needed here: the drift check reports all 19 types covered.

Provenance

Verified:

  • ruff check ., ruff format --check ., mypy src: clean at 3e42c6c
  • pytest: 1265 passed, 9 skipped (the gateway e2e test is skipped without credentials)
  • scripts/check_drift.py: models in sync; all 19 Router error types covered and blessed
  • scripts/check_public_repo_hygiene.py: no findings
  • PR CI at 3e42c6c: every check passes, including the four-version test matrix

Deviations:

  • None. The only hand-written change is the test adjustment described above.

@cloud-code-bot
cloud-code-bot Bot requested review from a team as code owners October 14, 2026 04:31
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@27afd6e) chore: sync vendored Comfy Router spec (cloud@06367520) Oct 20, 2026
@cloud-code-bot
cloud-code-bot Bot force-pushed the chore/sync-router-spec branch 2 times, most recently from a90c465 to 492f76b Compare October 21, 2026 00:20
@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@06367520) chore: sync vendored Comfy Router spec (cloud@41ed5d46) Oct 21, 2026
@cloud-code-bot
cloud-code-bot Bot force-pushed the chore/sync-router-spec branch from 492f76b to 9e56669 Compare October 21, 2026 02:32
@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@41ed5d46) chore: sync vendored Comfy Router spec (cloud@2f77c17f) Oct 21, 2026
@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@2f77c17f) chore: sync vendored Comfy Router spec (cloud@9f2ab43f) Oct 21, 2026
@cloud-code-bot
cloud-code-bot Bot force-pushed the chore/sync-router-spec branch from 9e56669 to 99b018c Compare October 21, 2026 19:54
@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@9f2ab43f) chore: sync vendored Comfy Router spec (cloud@1470316c) Oct 21, 2026
@cloud-code-bot
cloud-code-bot Bot force-pushed the chore/sync-router-spec branch from 99b018c to 8c45744 Compare October 22, 2026 08:49
@cloud-code-bot cloud-code-bot Bot changed the title chore: sync vendored Comfy Router spec (cloud@1470316c) chore: sync vendored Comfy Router spec (cloud@90a81a4b) Oct 22, 2026
The Router sync adds an optional If-None-Match header parameter to
GET /v2/models. The catalog contract test collected every parameter
regardless of location, so the header broke its cursor/limit check.
Match only the query parameters there, and assert that every
non-query parameter is optional, since models.list() never sends one.
@wei-hai
wei-hai merged commit 8185f0e into main Oct 22, 2026
12 checks passed
@wei-hai
wei-hai deleted the chore/sync-router-spec branch October 22, 2026 17:32
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants