-
Notifications
You must be signed in to change notification settings - Fork 1
fix: derive __version__ from dist metadata instead of hardcoding it #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| """``comfy_sdk.__version__`` is derived from the installed distribution | ||
| metadata rather than hardcoded. | ||
|
|
||
| publish.yml stamps the release tag into pyproject.toml at build time and | ||
| nowhere else, so a literal in ``__init__.py`` would silently report the | ||
| placeholder version on every published release while the wheel metadata (and | ||
| the User-Agent, which already reads dist metadata) said something different. | ||
|
|
||
| ``__version__`` is resolved once, at import time, so injecting a version means | ||
| patching the lookup *and* reloading the package — patching alone would assert | ||
| against the value bound when ``comfy_sdk`` was first imported. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import importlib | ||
| from collections.abc import Callable, Iterator | ||
| from contextlib import contextmanager | ||
| from importlib.metadata import PackageNotFoundError | ||
|
|
||
| import pytest | ||
|
|
||
| import comfy_sdk | ||
|
|
||
|
|
||
| @contextmanager | ||
| def reloaded_with(lookup: Callable[[str], str]) -> Iterator[str]: | ||
| """Re-import ``comfy_sdk`` with ``importlib.metadata.version`` replaced, | ||
| yielding the ``__version__`` it resolves to, then restore the real module. | ||
| """ | ||
| with pytest.MonkeyPatch.context() as mp: | ||
| mp.setattr("importlib.metadata.version", lookup) | ||
| importlib.reload(comfy_sdk) | ||
| try: | ||
| yield comfy_sdk.__version__ | ||
| finally: | ||
| # Undo the patch and reload again, so the rest of the suite sees | ||
| # the genuine installed version rather than the injected one. | ||
| mp.undo() | ||
| importlib.reload(comfy_sdk) | ||
|
|
||
|
|
||
| def test_version_comes_from_the_distribution_metadata() -> None: | ||
| with reloaded_with(lambda _name: "9.9.9") as version: | ||
| assert version == "9.9.9" | ||
|
|
||
|
|
||
| def test_version_falls_back_when_not_installed() -> None: | ||
| def missing(name: str) -> str: | ||
| raise PackageNotFoundError(name) | ||
|
|
||
| with reloaded_with(missing) as version: | ||
| assert version == "0+unknown" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.