ci: bump gh-action-pypi-publish to v1.14.2 so publishing accepts Metadata-Version 2.5 - #44
Merged
Merged
Conversation
…data-Version 2.5 The v0.1.6 publish failed at the upload step with InvalidDistribution: Invalid distribution metadata: '2.5' is not a valid metadata version The build job installs its tooling unpinned, so it now produces a wheel with Metadata-Version 2.5 and validates it with a current twine, which passes. The publish step then handed that wheel to the action pinned at v1.12.4 (Jan 2025), whose bundled packaging predates metadata 2.5 and rejects it. The two jobs were checking the same artifact with different tooling, so the build gate could not catch this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe publish workflow upgrades the PyPI and TestPyPI publishing action to v1.14.2 and documents its compatibility with Metadata-Version 2.5 artifacts. ChangesPublishing compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
pypa/gh-action-pypi-publishfrom v1.12.4 (Jan 2025) to v1.14.2, so the publish step can accept the wheels the build step produces.Why
The v0.1.6 publish failed at the upload step:
The
buildjob installs its tooling unpinned (pip install build twine), so it now builds a wheel carrying Metadata-Version 2.5 and validates it with a current twine — which passes. Thepublishjob then hands that same wheel to the action pinned at v1.12.4, whose bundled packaging predates metadata 2.5 and rejects it.The two jobs were validating the same artifact with different tooling versions, so the build-time gate structurally could not catch this —
twine checkpassed and the upload failed on the identical file.Scope
The one-line pin, applied to both the PyPI and TestPyPI steps (same action, same failure mode), plus a comment recording the version floor so the pin doesn't get rolled back.
Deliberately not included: pinning
build/twinein the build job. That would also prevent the drift and is arguably the more complete fix, but it's a separate decision about tooling policy and would put the repo on a manual upgrade treadmill — worth its own discussion rather than riding along here.Verification
The action bump can't be exercised before merge: the publish job only runs on a
releaseevent, andworkflow_dispatchis a build-only dry run that never reaches it. Checked instead:dc37677b2e1c63e2034f94d8a5b11f265b73ba33is the commitpypa/gh-action-pypi-publishtagv1.14.2dereferences to.packages-dir,skip-existing,repository-url) are unchanged between v1.12.4 and v1.14.2, so no call-site changes are needed.Real verification is the next release publishing successfully.
Follow-up
v0.1.6is tagged and the GitHub Release is published, but nothing reached PyPI (the failure is pre-upload, so the version number is still unused). Once this merges, the tag and Release need to be recreated at the newmainso the publish re-runs against the fixed workflow — the existing tag points at a commit that still carries v1.12.4.@comfyorg/sdk0.1.6 is already live on npm, so reusing 0.1.6 here keeps the two SDKs in lockstep.Summary by CodeRabbit