Repository navigation
Adopt Uno.Sdk tooling on Uno Platform 7.0 - #880
Draft
MartinZikmund wants to merge 6 commits into
Draft
MartinZikmund wants to merge 6 commits into
MartinZikmund wants to merge 6 commits into
Conversation
Squashed recreation of CommunityToolkit#862 on current main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Matches the tooling: .NET SDK 10.0.401, Uno.Sdk 7.0.0-dev.51, MSBuild.Sdk.Extras 3.0.44. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
DependencyObject is a class in Uno 7, so 'class, DependencyObject' fails with CS0450. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Uno 7 annotates the parameter as non-nullable. Use the overload without easing instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Uno returns List<AutomationPeer> instead of WinUI's IList<AutomationPeer>, fixed in unoplatform/uno#25141. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the toolkit to the Uno.Sdk-based tooling on Uno Platform 7.0 (WinUI 3). This recreates #862 on Uno 7 instead of 6.x.
Important
Draft. It depends on the tooling PR CommunityToolkit/Tooling-Windows-Submodule#317 and on Uno 7 dev builds. The submodule pointer references the tooling branch on a fork and will move to the merged commit.
Changes
linuxgtk→linux, newwin32MultiTarget, CI for the Uno.Sdk head).global.json: .NET SDK 10.0.401, Uno.Sdk 7.0.0-dev.51, MSBuild.Sdk.Extras 3.0.44.DOTNET_VERSIONandnet10.0-*TFMs.MSBuild.Sdk.Extras/3.0.23pins bumped to 3.0.44.DependencyObjectExtensions:where T : class, DependencyObjectonly on Uno 5 (HAS_UNO && WINUI2). DependencyObject is a class in Uno 7, so this was CS0450.CompositionExtensions.InsertExpressionKeyFrame: use the overload without easing wheneasingis null. Uno 7 annotates the parameter as non-nullable.TokenizingTextBoxAutomationPeer.GetChildrenCore: an#if HAS_UNO && WINUI3shim for Uno returningList<>instead ofIList<>. Fixed upstream in fix(automation): Align ListViewBaseAutomationPeer.GetChildrenCore return type with WinUI unoplatform/uno#25141; drop the shim once that ships.Validation
CommunityToolkit.App.Unobuilds fornet10.0-desktopwith 0 errors.RichTextBlock.Uno.Microsoft.Xaml.Behaviors.Interactivity.WinUIwas swapped for a local pack of feat: Update to Uno Platform 7.0 unoplatform/Uno.XamlBehaviors#36. The published 3.0.3 is built against Uno 5 and fails to compile in Behaviors/SettingsControls on Uno 7. That swap is not included here.Remaining before ready
Uno.Microsoft.Xaml.Behaviors.Interactivity.WinUI(Behaviors, SettingsControls samples) once Uno.XamlBehaviors#36 is published.🤖 Generated with Claude Code
https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC