Skip to content

CMP-3618 broke kubernetes remediation into two#14690

Open
vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
vickeybrown:CMP-3618-chrony-wait-fix
Open

CMP-3618 broke kubernetes remediation into two#14690
vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
vickeybrown:CMP-3618-chrony-wait-fix

Conversation

@vickeybrown
Copy link
Copy Markdown
Contributor

Description:

  • Split the Kubernetes remediation for chronyd_configure_local_socket
    between OCP 4.12 (RHEL 8) and OCP 4.13+ (RHEL 9)

Rationale:

  • OCP 4.12 is based on RHEL 8, which does not support all the systemd
    hardening directives used in the RHEL 9 version

  • OCP 4.13+ is based on RHEL 9, which fully supports these hardening
    directives

  • Fixes # CMP-3618

Review Hints:

  • The generated file should contain both MachineConfigs with the correct
    version annotations and different service file content (decode the URL-encoded
    data to verify)
  • Key difference: Line 11 has '<4.13.0' with shorter service file; Line 28
    has '>=4.13.0' with full hardening

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 30, 2026

Hi @vickeybrown. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 30, 2026
@Mab879 Mab879 added this to the 0.1.81 milestone May 1, 2026
@yuumasato
Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 4, 2026
@yuumasato yuumasato self-assigned this May 4, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 4, 2026

@vickeybrown: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance d4890c7 link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants