why does the CMakeList check to ensure you provide a custom HTTPClient callback when building as a static library? #36

Activity

1. ArtursKadikis commented on Jan 25, 2022

   

   ArtursKadikis

   on Jan 25, 2022

   Member

   More actions

   Which check specifically do you mean?
2. Zephilinox commented on Jan 26, 2022

   

   Zephilinox

   on Jan 26, 2022

   Author

   More actions

   sorry, I should have linked to it directly :) it's this one https://github.com/Countly/countly-sdk-cpp/blob/master/CMakeLists.txt#L16
3. ArtursKadikis commented on Jan 26, 2022

   

   ArtursKadikis

   on Jan 26, 2022

   Member

   More actions

   Hello. I'm not actually sure myself, the original developers are not part of the team anymore. After looking into git blame, it looks like they were added in this PR:
   #16

   And one of the issues it would fix is this:
   #15
4. Zephilinox commented on Jan 26, 2022

   

   Zephilinox

   on Jan 26, 2022

   Last edited by Zephilinox

   Author

   More actions

   hi :)

   Hello. I'm not actually sure myself, the original developers are not part of the team anymore.

   aw okay, no worries :)

   #16 fixes windows by excluding it from that check, so it wasn't the original reason for the check being added (for non-windows platforms) 🤔