Repository navigation
Wait for the lines logged after a request's removal before asserting them - #322
Merged
Merged
Conversation
…them Two tests waited until a request file was gone, then checked a line that the SDK logs only after it removes the file: the request drop age test the line of the request's owner, the backoff test the "not backing off" line of the last request. On a busy runner the check could run in between and fail, as the drop age test did on CI with "expected:<1> but was:<0>". Both now wait for their line with awaitLogs.
arifBurakDemiray
marked this pull request as ready for review
October 22, 2026 18:31
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two tests in
ModuleConfigurationNetworkTestswaited until a request file was gone, then checked a line that the SDK logs only after it removes the file:requestDropAge_settlesTheJourneyTriggerOfADroppedRequest_andALaterTriggerStillRefreshesDefaultNetworking.dropWithoutSending, which tells the owner afterremoveRequestbackoff_neverAfterARequestOlderThanTheRequestAge_norWhileTheServerTurnsItOffbackOffIfTheServerIsSlow, called in the send callback afterremoveRequestOn a busy runner the check could run in between. The drop age test failed this way 4 times on CI on 2026-10-22 (
expected:<1> but was:<0>), which keeps #275 red. Both tests now wait for their line with the file'sawaitLogshelper.The SDK keeps its order: telling the owner before the removal succeeds would report a drop that might not happen.
Verified
ModuleConfigurationNetworkTestson Java 8: 8 of 8 runs green.Not in this PR
sc_MV_ManualViewTests.MV_201A_autoStopped_pausedResumed_Legacyon Windows is a view-duration timing flake that also fails on master.🤖 Generated with Claude Code