feat(contrib): populate component tags from npm keywords - #1511
Draft
CAOShurong wants to merge 1 commit into
Draft
feat(contrib): populate component tags from npm keywords#1511CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
Fills component.tags from the npm package.json keywords property in ComponentBuilder, and serialises tags in both JSON and XML for CycloneDX 1.6 and later (tags were introduced in 1.6). - Add optional tags to the Component model and JSON/XML serialisation - Add supportsComponentTags to the spec protocol, gated to 1.6+ Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
jkowalleck
marked this pull request as draft
August 24, 2026 12:47
Member
|
Not considering this PR, unless you clearly state the use of AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1055
Summary
Adds
tagssupport to the Component model and populates it from the npmpackage.jsonkeywordsproperty inContrib.FromNodePackageJson.Builders.ComponentBuilder, serialising tags in both JSON and XML for CycloneDX 1.6 and later (tags were introduced in CycloneDX 1.6).Changes
src/models/component.ts: added optionaltags?: string[]toComponentandOptionalComponentPropertiessrc/contrib/fromNodePackageJson/types.ts: addedkeywords?: string[]toNodePackageJsonsrc/contrib/fromNodePackageJson/builders.ts:ComponentBuilder.makeComponentnow mapsdata.keywords(string or string[] form) intotagssrc/spec/_protocol.ts+src/spec/consts.ts: addedsupportsComponentTags, gated to CycloneDX 1.6 and 1.7src/serialize/json/normalize.ts+types.ts: emittagsin JSON output for 1.6+src/serialize/xml/normalize.ts: emit<tags><tag>..</tag></tags>in XML output for 1.6+tests/integration/.../ComponentBuilder.node.test.js:fullcase now includeskeywordsand expects the resultingtagsHISTORY.md: unreleased noteVerification
tsc --noEmitcleaneslintclean on changed files"tags":["alpha","beta"]and XML outputs<tags><tag>alpha</tag><tag>beta</tag></tags>for spec 1.7, andtagsis absent for 1.5 and earlier.