Fix #5332: Fix inconsistent rendering of <em> tag in system-wide aler…#5343
Merged
Conversation
…e alerts across views
lgeggleston
added
bug
ux
Contributor
|
@guillermo-escire pr_5343_converted.mp4 |
tdonohue
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
GauravD2t
approved these changes
May 16, 2026
Contributor
There was a problem hiding this comment.
Hello @guillermo-escire , I have tested this locally following the provided instructions. The <em> tag now renders consistently across all views (including /home and search pages) as expected and is no longer overridden by global bold styles.
Everything looks great. Appreciated the clear testing steps!
tdonohue
approved these changes
May 18, 2026
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @guillermo-escire ! This looks good to me too
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #5332
Description
Fixes inconsistent rendering of the tag in system-wide alerts by ensuring it is always displayed in italic across all views, regardless of conflicting global styles.
Instructions for Reviewers
List of changes in this PR:
How to test:
<h2>Test</h2><p><em>Lorem ipsum</em> <strong>dolor sit amet</strong></p>Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.