Skip to content

[Port dspace-9_x] Improve back navigation logic in ItemComponent#5631

Merged
tdonohue merged 2 commits into
DSpace:dspace-9_xfrom
dataquest-dev:backport-5170-dspace-9_x
May 6, 2026
Merged

[Port dspace-9_x] Improve back navigation logic in ItemComponent#5631
tdonohue merged 2 commits into
DSpace:dspace-9_xfrom
dataquest-dev:backport-5170-dspace-9_x

Conversation

@Kasinhou
Copy link
Copy Markdown
Contributor

@Kasinhou Kasinhou commented May 6, 2026

Bug: Improve back navigation logic in ItemComponent

References

Port of #5170

Description

Improves the "Back to results" button logic on item pages by adding session storage as a fallback for the previous URL. This ensures the back button works correctly across page refreshes and prevents stale navigation when users visit items from different contexts (e.g. homepage vs. collection browse).

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

tdonohue and others added 2 commits May 6, 2026 13:19
…tion

Bug: Improve back navigation logic in ItemComponent
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Kasinhou ! I've reviewed this and verified it's an accurate backport of #5170. It includes all the same changes except the dataset.component.spec.ts changes (as dataset support is new in 10.0 and shouldn't be included in 9.x)

@tdonohue tdonohue merged commit 4ac347a into DSpace:dspace-9_x May 6, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants