Skip to content

Fix Drag-and-Drop Malfunction in submission form - #6096

Open
FrankGameDev wants to merge 1 commit into
DSpace:dspace-9_xfrom
4Science:backport-DURACOM-487-to-dspace-9_x
Open

Fix Drag-and-Drop Malfunction in submission form #6096
FrankGameDev wants to merge 1 commit into
DSpace:dspace-9_xfrom
4Science:backport-DURACOM-487-to-dspace-9_x

Conversation

@FrankGameDev

Copy link
Copy Markdown

Porting of DURACOM-320 #6095

References

Description

Updated the CDK drag-and-drop behavior from horizontal to mixedto enable dropping chips on wrapped rows

Instructions for Reviewers

List of changes in this PR:

  • Changed the cdkDropListOrientation from horizontal to mixed

How to test the fix

Open a submission form, try adding some authors to let the chips wrap (or resize the browser/use DevTools to achieve it), and then try dragging and dropping chips onto different rows

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant