Skip to content

RUM-18142: Add setAnrTriggerEnabled opt-out API for ANR-triggered profiling - #3729

Merged
ambushwork merged 1 commit into
developfrom
yilu/rum-18142/anr-trigger-opt-out-api
Sep 22, 2026
Merged

ambushwork merged 1 commit into
developfrom
yilu/rum-18142/anr-trigger-opt-out-api

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Adds a new ProfilingConfiguration.Builder.setAnrTriggerEnabled(Boolean) API (default true) allowing customers to opt out of
ANR-triggered profiling.

Why

  • Billing: ANR-triggered profiles are uploaded and billed as profiling sessions. Customers now have a choice to disable them.
  • Trigger conflicts: Customers registering their own ProfilingTriggers can disable the SDK's ANR trigger to avoid cleanup conflicts.

Motivation

RUM-18142

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork

Copy link
Copy Markdown
Member Author

@codex review

@datadog-official

datadog-official Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 92.31%
• Overall Coverage: 71.81% (-0.11%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5f2423c | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35ed072187

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ambushwork
ambushwork force-pushed the yilu/rum-18142/anr-trigger-opt-out-api branch from 35ed072 to bd29d30 Compare August 19, 2026 11:03
@ambushwork
ambushwork marked this pull request as ready for review August 19, 2026 13:08
@ambushwork
ambushwork requested review from a team as code owners August 19, 2026 13:08
@ambushwork
ambushwork force-pushed the yilu/rum-18142/anr-trigger-opt-out-api branch from bd29d30 to 9a799bc Compare September 21, 2026 12:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T15:52:11.945496Z 5f2423c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ambushwork
ambushwork force-pushed the yilu/rum-18142/anr-trigger-opt-out-api branch from 9a799bc to aee4573 Compare September 21, 2026 13:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aee457333c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ambushwork
ambushwork force-pushed the yilu/rum-18142/anr-trigger-opt-out-api branch from aee4573 to 35779dc Compare September 21, 2026 13:24
@ambushwork
ambushwork requested a review from 0xnm September 21, 2026 14:59
@ambushwork
ambushwork force-pushed the yilu/rum-18142/anr-trigger-opt-out-api branch from 35779dc to 5f2423c Compare September 21, 2026 15:49
@ambushwork
ambushwork requested a review from 0xnm September 22, 2026 07:28
@ambushwork
ambushwork merged commit 8479108 into develop Sep 22, 2026
26 checks passed
@ambushwork
ambushwork deleted the yilu/rum-18142/anr-trigger-opt-out-api branch September 22, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants