Skip to content

Increase agent JAR size budget to 34.5 MiB - #13055

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
paul.fournillon/increase-agent-jar-budget-34.5
Oct 26, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
paul.fournillon/increase-agent-jar-budget-34.5

Conversation

@kaahos

@kaahos kaahos commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Raise the agent JAR budget from 34 to 34.5 MiB (+512 KiB).

Motivation

Accommodate ddprof 1.52.0 in #13044, leaving 44.8 KiB above its CI artifact.

Additional Notes

The increase mainly comes from ddprof’s new reference-chain/leak-signal engine and related liveness code across the four bundled Linux native libraries.

Contributor Checklist

  • Format the title according to the contribution guidelines.
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels.
  • Avoid using linking keywords when referencing an issue; use solves instead, and assign the PR milestone to the issue.
  • Update CODEOWNERS on source file addition, migration, or deletion.
  • Update public documentation with any new configuration flags or behaviors.
  • Once approved, use merge queue to merge the PR.

@kaahos kaahos added comp: profiling Profiling type: refactoring tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes labels Oct 26, 2026 — with ChatGPT Codex Connector
@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.92 s [+0.0%; +1.3%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.90 s 13.01 s [-1.4%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.06 s 17.01 s [-0.5%; +1.1%] (no difference)
startup:petclinic:iast:Agent 17.01 s 17.00 s [-0.7%; +0.7%] (no difference)
startup:petclinic:profiling:Agent 16.67 s 16.84 s [-2.1%; +0.1%] (no difference)
startup:petclinic:sca:Agent 17.08 s 16.38 s [-0.3%; +8.8%] (no difference)
startup:petclinic:tracing:Agent 16.12 s 16.26 s [-1.7%; -0.1%] (maybe better)

Commit: c4ba1bbc · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@kaahos
kaahos marked this pull request as ready for review October 26, 2026 13:22
@kaahos
kaahos requested a review from a team as a code owner October 26, 2026 13:22
@kaahos
kaahos requested review from sarahchen6 and removed request for a team October 26, 2026 13:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T13:24:48.957698Z c4ba1bb Draft marked ready
🔒 Security Review ✅ Completed 2026-10-26T13:25:25.218129Z c4ba1bb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4ba1bbc40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread metadata/agent-jar-checks.properties Resolved

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The configured limit correctly represents 34.5 MiB and remains compatible with the existing JAR size check.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit c4ba1bb

@jbachorik

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-26 15:28:57 UTC ℹ️ Start processing command /merge


2026-10-26 15:29:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-26 16:57:56 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit e7584c7 into master Oct 26, 2026
631 of 638 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the paul.fournillon/increase-agent-jar-budget-34.5 branch October 26, 2026 16:57
@github-actions github-actions Bot added this to the 1.69.0 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profiling Profiling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants