Skip to content

Remove stray <br> tags after card-grid shortcodes - #38764

Merged
hestonhoffman merged 1 commit into
masterfrom
heston/small-card-grid-fix
Aug 5, 2026
Merged

Remove stray <br> tags after card-grid shortcodes#38764
hestonhoffman merged 1 commit into
masterfrom
heston/small-card-grid-fix

Conversation

@hestonhoffman

@hestonhoffman hestonhoffman commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

The card-grid shortcode already provides bottom margin, making the extra manual <br> line breaks after it redundant. I suspect these might also have some negative impact on the plaintext build in some situations.

Merge readiness

  • Ready for merge

For Datadog employees:

  • ⚠️ Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR.
  • 🤖 New: Comment with /review to run an automated check that catches common issues before a Documentation team member reviews your PR.

AI assistance

Additional notes

The card-grid shortcode already provides bottom margin, making the
extra manual <br>/</br> line breaks after it redundant.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@hestonhoffman
hestonhoffman requested review from a team as code owners August 4, 2026 21:58
@hestonhoffman hestonhoffman added the Do Not Merge Just do not merge this PR :) label Aug 4, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Removing the trailing break tags preserves document structure: standalone Hugo rendering kept card grids, following paragraphs, headings, and ordered lists as separate elements, while the shortcode's existing bottom margin continues to provide spacing. No diff-only behavioral regression was reproduced; the repository-wide build could not run because its external Hugo module was unavailable.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit c176e36 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@hestonhoffman hestonhoffman removed the Do Not Merge Just do not merge this PR :) label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@domalessi domalessi self-assigned this Aug 5, 2026
@hestonhoffman
hestonhoffman merged commit fe569e4 into master Aug 5, 2026
35 of 39 checks passed
@hestonhoffman
hestonhoffman deleted the heston/small-card-grid-fix branch August 5, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants