Repository navigation
Use a small table in PutWithExistingIdNoInfiniteLoopWhenFull - #847
Merged
Merged
Conversation
The test filled a 65536-slot table and then made 128 more inserts, each probing the whole table before giving up. Under TSan that took close to its fixed 10 s deadline and failed intermittently on CI runners (seen in gtest-tsan-arm64 and gtest-tsan-amd64). The regression it guards, a probe cycling forever once the table is full, does not depend on the table size, so seed a 1024-slot table instead. The test now runs in ~60 ms under TSan, keeps the deadline as a hang detector, and checks that inserts beyond the capacity were dropped, i.e. that the full-table path actually ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Contributor
CI Test ResultsRun: #37897230469 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-09 07:27:05 UTC |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Makes
CallTraceStorageTest.PutWithExistingIdNoInfiniteLoopWhenFullseed a 1024-slot table (through the existingCallTraceHashTableTestAccessor) instead of filling the default 65536-slot one. It also checks that inserts beyond the capacity were dropped, i.e. that the full-table path the test is about actually ran.Motivation:
The test filled 65536 slots, then made 128 more inserts, each probing the whole table before giving up. Under TSan that takes close to the test's fixed 10 s deadline, and it failed intermittently on CI:
gtest-tsan-arm64on Never reclaim dictionary storage after a timed-out drain #839 (31ab198);gtest-tsan-amd64on Close guard-scan and reused-buffer gaps in dictionary reclamation #845 (7c24b1c).Both times it was the only failing test, with no TSan reports, and the same code passed in other pipelines.
The regression it guards, a probe that cycles forever once the table is full, does not depend on the table size.
putWithExistingId()never expands a table, so a small seeded table fills up and takes the samehasNext()give-up path.Additional Notes:
The 10 s deadline stays as the hang detector. The test-only accessor moves above this test so that it is defined before its first use; its content is unchanged.
How to test the change?:
gtestDebug_test_callTraceStorage,gtestAsan_test_callTraceStorage,gtestTsan_test_callTraceStorage: the test now runs in ~52-61 ms in each configuration (previously close to 10 s under TSan).For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.🤖 Generated with Claude Code