Repository navigation
Conversation
|
This pull request modifies a sensitive codepath in 'dojo/finding/queries.py' by an author not on the allowed list. However, the finding is classified as low severity and is not blocking.
Configured Sensitive Codepath Modified by Non-Allowed Author in
|
| Vulnerability | Configured Sensitive Codepath Modified by Non-Allowed Author |
|---|---|
| Description | File 'dojo/finding/queries.py' matches configured sensitive codepath pattern 'dojo/finding/*.py' and was modified by 'euvoor' (commit a05d0cb) who is not in the allowed authors list. |
Comment to provide feedback on these findings.
Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]
Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing
All finding details can be found in the DryRun Security Dashboard.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16728.
The findings list prefetched endpoint statuses, but rendering each status still fetched its endpoint separately. Join each endpoint into the status prefetch in the legacy endpoint path.
For a warmed page containing 12 findings with three endpoints each, this removes all 36 individual endpoint lookups and reduces total queries from 97 to 61. The existing endpoint prefetch stays in place for the template's existence check. Endpoint ordering, status counts and the Locations path are unchanged.
Test results
Added regression coverage for both All Findings and Open Findings, one versus twelve findings, endpoint URLs and status markers, and findings without endpoints. The query regressions fail on the base revision and pass with this fix.
Validation used Python 3.14.8 and PostgreSQL 17.11. The full test suite was not run.
Documentation
No user-facing behavior, configuration or schema changes.
Checklist
dev.dev.