Skip to content

Scheduler - Migrate popup resources and save/cancel tests to isolated environment#33786

Open
bit-byte0 wants to merge 2 commits into
DevExpress:26_1from
bit-byte0:test/scheduler-migrate-popup-resources-save-tests
Open

Scheduler - Migrate popup resources and save/cancel tests to isolated environment#33786
bit-byte0 wants to merge 2 commits into
DevExpress:26_1from
bit-byte0:test/scheduler-migrate-popup-resources-save-tests

Conversation

@bit-byte0
Copy link
Copy Markdown
Contributor

@bit-byte0 bit-byte0 commented Jun 2, 2026

What

Migrate 15 tests from integration to isolated createAppointmentPopup() helper (Form + Popup only, no full Scheduler)

How

Groups: Resources (6), Icons (2), Save/Cancel (7).
No production code changes, only test helper gets resources option.

@bit-byte0 bit-byte0 self-assigned this Jun 2, 2026
@bit-byte0 bit-byte0 requested a review from a team as a code owner June 2, 2026 09:00
Copilot AI review requested due to automatic review settings June 2, 2026 09:00
@bit-byte0 bit-byte0 added the 26_1 label Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates several Scheduler Appointment Popup resource-related checks and save/cancel behavior tests from the integration suite into the isolated AppointmentPopup test environment, reducing reliance on full Scheduler integration for popup-specific behavior.

Changes:

  • Added isolated-environment tests covering resource group structure, resource editor widget types, FontAwesome resource icons, and subject icon color updates.
  • Moved save/cancel behavior assertions into isolated tests by validating onSave callback behavior for common and recurring appointments.
  • Extended the AppointmentPopup test factory to accept Scheduler-like resources configuration and preload resource data when provided; removed the migrated tests (and now-unused types) from the integration suite.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts Adds isolated AppointmentPopup tests for resources, icons, and save/cancel behavior.
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts Removes resource and save/cancel tests that were migrated to the isolated suite and drops an unused type import.
packages/devextreme/js/__internal/scheduler/tests/mock/create_appointment_popup.ts Extends the isolated popup factory to accept resources and preload them before showing the popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants