Skip to content

fix(pdu): parse ClearCodec V-Bar offsets - #1694

Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/clearcodec-v-bar-offsets
Aug 18, 2026
Merged

fix(pdu): parse ClearCodec V-Bar offsets#1694
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/clearcodec-v-bar-offsets

Conversation

@mamoreau-devolutions

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Decode short V-Bar cache-miss offsets from their specified bit positions.

@mamoreau-devolutions
fix(pdu): parse ClearCodec V-Bar offsets
ccc8e5d 
Decode short V-Bar cache-miss offsets from their specified bit positions.
Copilot AI balanced review requested due to automatic review settings August 18, 2026 00:13
Copilot AI reviewed Aug 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects ClearCodec short V-Bar cache-miss decoding to match MS-RDPEGFX bit positions.

Changes:

  • Decodes y_on from bits 7:0 and y_off from bits 13:8.
  • Updates the regression test encoding accordingly.

@github-actions github-actions Bot added kind/protocol Affects RDP or related protocol behavior maintainer-required Maintainer review or intervention is required risk/medium Behavioral change that does not substantially alter a core public API scope/core Touches the core architectural tier size/XS Size: up to 49 counted lines and 2 files labels Aug 18, 2026
@github-actions github-actions Bot added the ai-reviewed/1 One automated review completed label Aug 18, 2026
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit c1db860 into master Aug 18, 2026
44 checks passed
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) deleted the copilot/clearcodec-v-bar-offsets branch August 18, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

ai-reviewed/1 One automated review completed kind/protocol Affects RDP or related protocol behavior maintainer-required Maintainer review or intervention is required risk/medium Behavioral change that does not substantially alter a core public API scope/core Touches the core architectural tier size/XS Size: up to 49 counted lines and 2 files

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mamoreau-devolutions