fix(egfx): honor the server's AVC_DISABLED during negotiation - #1731
Draft
Hojjat Abdollahi (hojjatabdollahi) wants to merge 1 commit into
Draft
fix(egfx): honor the server's AVC_DISABLED during negotiation#1731Hojjat Abdollahi (hojjatabdollahi) wants to merge 1 commit into
Hojjat Abdollahi (hojjatabdollahi) wants to merge 1 commit into
Conversation
`AVC_DISABLED` is an inverted-sense flag: a peer sets it to say it cannot handle AVC/H.264. Devolutions#1490 stopped AND-ing away the *client's* copy, but the server's copy is still dropped whenever the client leaves it clear. That misreports servers which cannot produce AVC at all, such as one streaming only RemoteFX Progressive: it sets AVC_DISABLED, negotiation clears it, and the capabilities confirmation promises the client a codec that will never arrive. OR the flag from both sides instead, so it survives when either peer disables it, and cover the server case in the negotiation tests.
Hojjat Abdollahi (hojjatabdollahi)
temporarily deployed
to
llm-providers
August 20, 2026 22:46 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
kind/protocol
Hojjat Abdollahi (hojjatabdollahi)
marked this pull request as draft
August 21, 2026 00:37
Author
|
Draft, until I make sure my assumption was correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AVC_DISABLEDis an inverted-sense flag: a peer sets it to say it cannot handle AVC/H.264. #1490 stopped AND-ing away the client's copy, but the server's copy is still dropped whenever the client leaves it clear.That misreports servers which cannot produce AVC at all, such as one streaming only RemoteFX Progressive: it sets AVC_DISABLED, negotiation clears it, and the capabilities confirmation promises the client a codec that will never arrive.
OR the flag from both sides instead, so it survives when either peer disables it, and cover the server case in the negotiation tests.
For positive flags they are still AND-ed but for AVC_DISABLED, which is negative it is OR-ed so if either side sets it, it's enough.