Skip to content

ci(xtask): enforce centralized integration tests - #1749

Open
Benoît Cortier (CBenoit) wants to merge 3 commits into
cbenoit-centralize-tls-rdpdr-testsfrom
cbenoit-enforce-test-target-policy
Open

ci(xtask): enforce centralized integration tests#1749
Benoît Cortier (CBenoit) wants to merge 3 commits into
cbenoit-centralize-tls-rdpdr-testsfrom
cbenoit-enforce-test-target-policy

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Cargo metadata now rejects integration-test targets outside the centralized suites.

Run the checker in cargo xtask ci and as an independent CI job.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure labels Aug 21, 2026
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-enforce-test-target-policy branch from cf1a567 to fb79208 Compare August 21, 2026 10:03
Copilot AI balanced review requested due to automatic review settings August 21, 2026 10:29
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-enforce-test-target-policy branch from fb79208 to 3377856 Compare August 21, 2026 10:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enforces centralized Cargo integration-test targets through xtask and CI.

Changes:

  • Validates Cargo metadata against approved test suites.
  • Adds CLI wiring and validator unit tests.
  • Adds an independent CI gate.

Protocol and documentation reviews were not applicable.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
xtask/src/main.rs Runs the new check.
xtask/src/cli.rs Exposes check test-targets.
xtask/src/check.rs Implements validation and tests.
.github/workflows/ci.yml Adds the required CI job.

Comment thread xtask/src/check.rs Outdated
Cargo metadata now rejects integration-test targets outside the centralized suites.

Run the checker in cargo xtask ci and as an independent CI job.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the test-target metadata parser aligned with the xtask single-use helper convention.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep Cargo metadata parsing and its regression coverage in a focused module.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-required Maintainer review or intervention is required risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure

Development

Successfully merging this pull request may close these issues.

3 participants