feat(mstsgu): add TsProxy control stub codecs - #1758
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits intoAug 22, 2026
Merged
feat(mstsgu): add TsProxy control stub codecs#1758Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Conversation
Stage bounded NDR32 codecs for the initial TsProxy control sequence. Keep the codecs internal and transport-free.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 21, 2026 23:59 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 21, 2026 23:59
View session
github-actions
Bot
added
kind/protocol
Contributor
There was a problem hiding this comment.
Pull request overview
Adds internal, bounded NDR32 codecs for the initial TsProxy control sequence.
Changes:
- Adds request encoders and response decoders for three TsProxy operations.
- Adds protocol validation, bounds, errors, and unit tests.
- Registers a dedicated codec test target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/rpc.rs |
Implements and tests TsProxy control-stub codecs. |
crates/ironrdp-mstsgu/Cargo.toml |
Registers the codec tests. |
Validate negotiated capabilities, failure statuses, optional NDR arrays, protocol versions, and reserved fields before exposing decoded outputs. Preserve quarantine response data and make the dedicated test target compatible with workspace Clippy.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 22, 2026 01:51 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
risk/unknown
Marc-André Moreau (mamoreau-devolutions)
merged commit Aug 22, 2026
44a3bbb
into
master
43 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/tsproxy-control-codecs
branch
August 22, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage bounded NDR32 codecs for the initial TsProxy control sequence.
Keep the codecs internal and transport-free.