Repository navigation
test(core): import the clipboard helpers in the lock lifecycle tests - #2066
Conversation
Devolutions#2056 moved the clipboard test helpers into ironrdp_testsuite_core::clipboard while Devolutions#1981 added tests to lock_lifecycle.rs that still used super::test_helpers. Each was green when it merged, so master's testsuite-core tests stopped compiling. Import the two helpers from the library instead.
There was a problem hiding this comment.
🟢 Test-only compile fix for crates/ironrdp-testsuite-core/tests/clipboard/lock_lifecycle.rs, whose two lock-lifecycle tests still referenced helpers via super::test_helpers after the helpers moved into the ironrdp_testsuite_core::clipboard module, breaking the testsuite crate's tests on master with E0433. The PR imports init_ready_locking_client and set_remote_file_list from ironrdp_testsuite_core::clipboard alongside the existing helper imports and drops the stale super::test_helpers:: prefix at all six call sites. Verified in pr-head: both helpers exist as pub fn in crates/ironrdp-testsuite-core/src/clipboard.rs (lines 483 and 497), no test_helpers references remain in the test file, and call-site signatures match the helpers. No production code, protocol logic, or public API is affected; the change is minimal and correct.
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
Thank you Greg!
#2056 moved the clipboard test helpers into
ironrdp_testsuite_core::clipboard, and #1981 added two tests tolock_lifecycle.rsthat still reach them throughsuper::test_helpers. The two PRs were each green when they merged, so neither CI run saw the combination, andironrdp-testsuite-core's tests no longer compile on master:This imports
init_ready_locking_clientandset_remote_file_listfrom the testsuite library, next to the other helpers that file already imports, and drops thesuper::test_helpers::prefix at the six call sites. Nothing else changes.cargo xtask check fmt,lints,typos,locksandtestsall pass with it.