Skip to content

test(core): import the clipboard helpers in the lock lifecycle tests - #2066

Merged
Benoît Cortier (CBenoit) merged 1 commit into
Devolutions:masterfrom
lamco-admin:fix/clipboard-test-helpers-import
Oct 1, 2026
Merged

Benoît Cortier (CBenoit) merged 1 commit into
Devolutions:masterfrom
lamco-admin:fix/clipboard-test-helpers-import

Conversation

@glamberson

Copy link
Copy Markdown
Contributor

#2056 moved the clipboard test helpers into ironrdp_testsuite_core::clipboard, and #1981 added two tests to lock_lifecycle.rs that still reach them through super::test_helpers. The two PRs were each green when they merged, so neither CI run saw the combination, and ironrdp-testsuite-core's tests no longer compile on master:

error[E0433]: failed to resolve: could not find `test_helpers` in `super`
   --> crates/ironrdp-testsuite-core/tests/clipboard/lock_lifecycle.rs:654:30

This imports init_ready_locking_client and set_remote_file_list from the testsuite library, next to the other helpers that file already imports, and drops the super::test_helpers:: prefix at the six call sites. Nothing else changes.

cargo xtask check fmt, lints, typos, locks and tests all pass with it.

Devolutions#2056 moved the clipboard test helpers into ironrdp_testsuite_core::clipboard while Devolutions#1981 added tests to lock_lifecycle.rs that still used super::test_helpers. Each was green when it merged, so master's testsuite-core tests stopped compiling. Import the two helpers from the library instead.
@github-actions github-actions Bot added risk/low Self-contained change with no cross-crate behavioral effect size/XS Size: up to 49 counted lines and 2 files labels Oct 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Test-only compile fix for crates/ironrdp-testsuite-core/tests/clipboard/lock_lifecycle.rs, whose two lock-lifecycle tests still referenced helpers via super::test_helpers after the helpers moved into the ironrdp_testsuite_core::clipboard module, breaking the testsuite crate's tests on master with E0433. The PR imports init_ready_locking_client and set_remote_file_list from ironrdp_testsuite_core::clipboard alongside the existing helper imports and drops the stale super::test_helpers:: prefix at all six call sites. Verified in pr-head: both helpers exist as pub fn in crates/ironrdp-testsuite-core/src/clipboard.rs (lines 483 and 497), no test_helpers references remain in the test file, and call-site signatures match the helpers. No production code, protocol logic, or public API is affected; the change is minimal and correct.

@github-actions github-actions Bot added ai-reviewed/1 One automated review completed needs-review A human reviewer is the current next actor labels Oct 1, 2026
@clintcan

clintcan commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Confirmed: I hit the same break while running ironrdp-testsuite-core on master today (#1981 landed after #2056 moved the helpers), and my local fix touched the same six call sites. With this applied, testsuite-core builds and passes locally. Thanks for picking it up.

@CBenoit Benoît Cortier (CBenoit) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Greg!

@CBenoit
Benoît Cortier (CBenoit) merged commit 625c020 into Devolutions:master Oct 1, 2026
42 checks passed
@glamberson
Greg Lamberson (glamberson) deleted the fix/clipboard-test-helpers-import branch October 19, 2026 21:54

This branch was previously deployed

1 inactive deployment
llm-providers — 3831322f Deployed Oct 1, 2026 by glamberson via Classify pull request #1483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed/1 One automated review completed needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect size/XS Size: up to 49 counted lines and 2 files

Development

Successfully merging this pull request may close these issues.

3 participants