Never show the main window on a daemon launch - #5303
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
August 20, 2026 13:37
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents unconditional main-window display during daemon startup while supporting startup dialogs and safe geometry persistence.
Changes:
- Skips showing the main window in daemon mode.
- Temporarily displays hidden windows for startup dialogs.
- Avoids saving geometry before layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
App.axaml.cs |
Updates startup visibility and crash-dialog handling. |
AvaloniaBootstrapper.cs |
Adds consistent hidden-owner dialog handling. |
MainWindow.axaml.cs |
Guards against invalid geometry persistence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 20, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the main window is managed during daemon (background) launches and when showing dialogs at startup. The changes ensure that the main window is only shown when necessary, preventing unwanted window flashes and fixing issues where dialogs could not be displayed if the window was hidden. It also prevents saving invalid window geometry when the window hasn't been displayed yet.
Window visibility and dialog management:
ShowStartupDialogAsyncfor consistency.Window geometry persistence:
SaveGeometryNowmethod now checks if the window has been laid out (i.e., has valid width and height) before saving geometry, preventing saving a 0x0 window size when the window hasn't been shown (such as in daemon launches).