feat(vmm): add a status filter to the console instance list - #1193
Merged
Merged
Conversation
The console could search by keyword but not by lifecycle status. The list is paginated server-side, so a client-only filter would only cover the current page and would report the wrong total. Add StatusRequest.status and apply it in list_vms before pagination, using the same running/stopped/exited/stopping/removing values already shown in the Status column. Empty status keeps the previous all-status behavior. The toolbar select resets to page 1, matching page-size changes. Status computation is shared through vm_runtime_status so the filter and the list agree. Verified with `npm run build` in dstack/vmm/ui, `cargo check -p dstack-vmm-rpc`, and prek on the changed files.
Leechael
force-pushed
the
feat/vmm-ui-status-filter
branch
from
September 15, 2026 07:24
ab4ca7d to
3b75a4c
Compare
prek and cargo fmt --check failed on the four-item use super line introduced while resolving the rebase conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The VMM console can search instances by keyword, but not by lifecycle status. The list is paginated server-side, so a client-only filter would only cover the current page and would report the wrong total.
Fix
StatusRequest.status(running,stopped,exited,stopping,removing). Empty keeps the previous all-status behavior.list_vmsbefore pagination, using the same status values already shown in the Status column.vm_runtime_statusso the filter and the list agree.Old clients omit the field, so existing
Statuscallers are unchanged.Verification
npm run buildindstack/vmm/uicargo check -p dstack-vmm-rpcprekon the changed files