Repository navigation
fix(gateway): bound every peer HTTPS exchange by the sync timeout - #1374
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpsClient(hyper-util legacy client) has no connect or request timeout.SyncManagerbounds sync rounds withsync.timeout, butfetch_peers_from_bootnodecalls the client directly, both inProxyInner::new(before the proxy binds its listeners) and in the retry loop. A bootnode that completes the TLS handshake and never answers hangs the gateway at startup.HttpsClientConfiggains atimeout, set fromsync.timeout(30s default), applied to each request including the body read.Verification: new test
a_peer_that_never_answers_does_not_hang_the_client(before the fix:Elapsed(())after 10s).cargo test -p dstack-gateway309 passed; fmt and clippy clean.