Repository navigation
Move supported CPU/accelerator targets per EESSI version into a TOML file for easier reuse - #1745
Merged
Merged
Conversation
…file The list of supported CPU and accelerator targets per EESSI version was embedded as env variables in test-software.eessi.io.yml. Move it to .github/workflows/eessi_targets.json so it can be reused by other workflows and scripts (e.g. a check on the bot's build status), without duplicating it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Instance
|
yq infers its output format from the input file extension, so reading a .json file produced quoted JSON strings (e.g. "x86_64/amd/zen2"), which broke the CPU target detection. jq -r prints raw strings. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…facts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
Logs can now be found in https://github.com/EESSI/software-layer/actions/runs/37325488600?pr=1745 (for the next 14 days). Seems to work completely as intended: I see all of the expected CPU targets for the |
casparvl
marked this pull request as ready for review
October 5, 2026 15:32
ocaisa
requested changes
Oct 5, 2026
ocaisa
left a comment
ocaisa
left a comment
Member
There was a problem hiding this comment.
I lean towards yaml just because then we can add comments.
I don't see much point in keeping all the output as artefacts
TOML is parseable from Python's standard library (tomllib, 3.11+) and from the shell with yq, and unlike JSON it allows comments. yq is called with explicit input/output formats (-p toml -o yaml) so the output is raw strings, rather than relying on yq inferring the output format from the file extension. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
casparvl
changed the title
ocaisa
reviewed
Oct 6, 2026
ocaisa
approved these changes
Oct 6, 2026
ocaisa
left a comment
ocaisa
left a comment
Member
There was a problem hiding this comment.
LGTM will just check the CI run and merge
Member
|
Ah, indeed it is still working, it is catching problems caused by other ingestions happening! https://github.com/EESSI/software-layer/actions/runs/37466497312/job/112278793441 |
ocaisa
enabled auto-merge
October 6, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of supported CPU and accelerator targets per EESSI version was embedded as env variables in test-software.eessi.io.yml. Move it to .github/workflows/eessi_targets.toml so it can be reused by other workflows and scripts (e.g. a check on the bot's build status), without duplicating it.
Marked as Draft since we should probably first add something in an easystack file, and see if the workflows still run correctly, before reviewing / merging is even an option.