Repository navigation
Fix/v9 test issues - #2562
Merged
Merged
Fix/v9 test issues#2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the test suite safe for parallel execution
EPPlusTest runs with MSTest parallelization at method level. This PR fixes the intermittent failures this caused.
Library fix
StructureKeys: a static lookup dictionary was filled lazily without locking. Concurrent first use from separate packages could corrupt it, or silently returnnulldata types for cell picture keys. The table is now built once in the type initializer and only read afterwards.Tests
[DoNotParallelize]to classes that share a static workbook or change process-wide state (license, global configuration).SaveAndCleanupnow includes the inner exception in the message (MSTest hides it forClassCleanupfailures) and disposes the package when saving fails.StructureKeysTests: table content, a guard against mutable static fields, and a parallel cell picture smoke test.Verification
Full suite (~6,700 tests) green twice per target framework (net8.0, net481).