Add workflow to build pyodide package - #3128
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3128 +/- ##
=======================================
Coverage 73.15% 73.16%
=======================================
Files 430 430
Lines 103937 103967 +30
Branches 16717 16718 +1
=======================================
+ Hits 76039 76069 +30
Misses 27622 27622
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
LGTM if @mathgeekcoder is happy as well |
|
Should be unrelated but we get a first sanitizer failure here @Opt-Mucca would you look at it please? |
|
@galabovaa Can do! |
|
@Opt-Mucca Also note that I have excluded test_user_interrupts and test_with_context_manager tests from pyodide build as those depends on threads/multithreading, which pyodide doesn't support and those tests are falling |
|
@airen1986 Just to clarify: That comment is unrelated to the sanitizer build being run in this pipeline? |
yes, it is unrelated, just something to note for the team |
|
@galabovaa Locally I'm not getting any errors for |
I'm a little hesitant to approve just yet. I don't know what the ramifications are with officially(?) supporting WASM. As @airen1986 mentioned, threading isn't really supported. I think we might need to make some minor changes to highspy. I don't know if changes are required for the C++ threading etc. too. |
|
I should've mentioned that I think this sounds really cool though! |
|
@mathgeekcoder just checking if you have any thought on this? Are we planning it for some release or not planned yet? |
@galabovaa is just back from holiday, and should be able to comment soon |
|
Hello @galabovaa, any plan to merge this to main? |
|
Hi @airen1986, I have added some tests for this wheel on another branch. We are still considering adding this, but need to make sure to add the correct build flags, tests and documentation updates. |
|
Added this to feature requests until I get around to finish the updates. Closing for now |
With the acceptance of PEP 783, package maintainers can now build and publish Pyodide-compatible wheels (pyemscripten platform) directly to PyPI. Submiting this PR to build python package in HiGHS repository, will update the code in build-wheels-push.yml, so pyodide packages can be uploaded to PyPI