Keep implications between restarts - #3209
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3209 +/- ##
==========================================
+ Coverage 73.17% 73.20% +0.02%
==========================================
Files 445 445
Lines 107802 107876 +74
Branches 17258 17282 +24
==========================================
+ Hits 78887 78970 +83
+ Misses 28639 28630 -9
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
reviewed
Aug 24, 2026
fwesselm
left a comment
Collaborator
There was a problem hiding this comment.
Looks good @Opt-Mucca!
…-implications-between-restarts
…com/fwesselm/HiGHS into keep-implications-between-restarts
Collaborator
Author
|
This change has come out as performance neutral (0.01% performance improving), but is mostly there to enable future presolve rules to use any implication information. Therefore it should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the data structure holding implication information to a
HighsHashTree(similar to vbs). It now transfers implication information between restarts, shrink-problem calls, and sub-mips. This has been a long-standing TODO in the code, but with low priority because it's not going to be too performance changing.Pros:
Cons:
Testing locally I'm getting a 0.5% slowdown but solving two more instances. I'd say this is mostly noise and I'd wait for @fwesselm to try it on a larger test set.