[docker] consolidate dockerfiles#1007
Conversation
|
Converting to draft again, I think I want to also separate To be discussed briefly. |
58554e6 to
58d208a
Compare
58d208a to
a26cd8b
Compare
This allows us to parameterise later layers on earlier ones. In practice, I want to use this to avoid rebuilding the `base` layer in PR and merge queue runs, building it only on `main` and release branches and tags. As a drive-by bonus, this means we can cache the `base` and `build` layers for reuse when building the `test` layer. I've also added a hook to allow building from a local working copy. (By providing an EC_REPO argument when building the `test` target.) This should allow us to pre-build the test image once and for all for all post-build checks. (Using `.` as EC_REPO, perhaps—haven't really thought that far.)
a26cd8b to
7019e6d
Compare
|
@strub this is now ready for review. It is only a refactor, which should not change any measurable behaviour (including on build time), but gives us the flexibility to change measurable behaviour later down the line. (In practice, a build of the See #1008 to see how I intend to use this to shortcut the PR builds. |
|
A happy and coincidental side effect of this is to make the build possible using |
This allows us to parameterise later layers on earlier ones.
In practice, I want to use this to avoid rebuilding the
baselayer in PR and merge queue runs, building it only onmainand release branches and tags. As a drive-by bonus, this means we can cache thebaseandbuildlayers for reuse when building thetestlayer.I've also added a hook to allow building from a local working copy. (By providing an EC_REPO argument when building the
testtarget.) This should allow us to pre-build the test image once and for all for all post-build checks. (Using.as EC_REPO, perhaps—haven't really thought that far.)