Update Debian bullseye to trixie, Python 3.9 to 3.13, libsecp256k1-zkp to current master#530
Merged
Conversation
Contributor
Author
|
@whitslack would you mind building this in your build environment to see if anything breaks? Note the library version numbers won't be bumped until just before a new release is made. |
Contributor
|
I tested several combinations of There are some QA warnings, though:
(I don't believe the above warnings are introduced by this PR.) Also a couple of compiler warnings: |
Contributor
Author
|
Nice, thanks! I'll take a look at the warnings. |
Contributor
Author
|
@whitslack fixed the warnings except the license expression one which we will update when we remove support for python 3.9. |
5518161 to
078a8ce
Compare
Node v20 is EOL; move to v24. The latest emsdk is now available on both amd64 and arm64, so update that too. update-java-alternatives is unneeded (and broken) on trixie, so don't run it. Fix JAVA_HOME to work on amd64 and arm64.
This builds amd64 and arm64 images for the same commit ref. Note the location of the docker image has changed from "greenaddress/" to "blockstream/".
Optionality means we don't need our previous hack from commit d6b1fe2.
Run valgrind tests on the test binaries not the libtool wrapper scripts.
Since the swig python tests were updated to build the python wheel using setup.py, 'make check' has issues due to the wheel build reconfiguring the source tree when being built while the other tests are running. Change this to run all other tests before the swig python tests; This fixes 'make check' including for parallel builds.
Something in the secp aux macros breaks when building the sdist and wheel at the same time. Build them separately to work around this. Note that we only want the sdist artifact; the wheel is just used for smoke testing before producing the sdist.
Note this means that java v20+ is now required for testing.
Fixes the obsolete version warning when building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.