Repository navigation
Fix held-slot exclusion in stored items and allow console commands with explicit target - #64
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
collectStoredItems removed the first stack equal to the held one, which could be a stack from another slot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Class, xp and inventory commands rejected the console even when a target player was specified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
osipxd
force-pushed
the
fix/player-inventory-bugs
branch
from
November 10, 2026 21:18
c265cce to
d291d6e
Compare
osipxd
enabled auto-merge (rebase)
November 10, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory
BukkitPlayerInventory.collectStoredItemsremoved the held item withminus(itemInMainHand), which drops the first equal stack rather than the held slot. With two equal stacks, the wrong instance was excluded. Now the held slot is filtered byheldItemSlotindex. Added a regression test inMinecraftPlayerInventoryTest.Commands
/mimic inventory info <player>,/mimic class info <player>,/mimic class check <player> <classes>and/mimic xp ... <player>were player-only even when a target is given. The target forms now useexecutesAny; forms without a target stay player-only.getPlayerOrDefaultis replaced withgetPlayerOrSender.Not tested on a live server: console execution of these commands.
🤖 Generated with Claude Code